[AI-FSSDK] [FSSDK-12760] Add localHoldouts datafile section for backward compat#517
Open
jaeopt wants to merge 3 commits into
Open
[AI-FSSDK] [FSSDK-12760] Add localHoldouts datafile section for backward compat#517jaeopt wants to merge 3 commits into
jaeopt wants to merge 3 commits into
Conversation
Update stale docstrings/comments that described holdout scope as being
determined by the includedRules field. After FSSDK-12760, scope is
determined by which top-level datafile section the entity is parsed
from ('holdouts' = global, 'localHoldouts' = local). The entity-level
is_global property continues to compute from included_rules for code
holding direct entity references.
No behavior change.
Condense the spec §5 cleanup comments to one-line/short-docstring form per updated spec guidance. Same content, more compact.
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the new top-level
localHoldoutsdatafile section so a single datafile can serve every SDK generation safely. Older SDKs ignore the unknown key; this SDK now parses it as the source of truth for rule-scoped (local) holdouts, whileholdoutsis treated as global-only — section membership is the sole signal for scope.Changes
localHoldoutsas a separate top-level array; entries register against each rule inincludedRules.holdoutsas global; anyincludedRulesfield on those entries is stripped and ignored.includedRules) with an error log instead of silently promoting them to global.localHoldoutskey continue to behave exactly as before.Jira Ticket
FSSDK-12760