[FSSDK-12759] fix content-length header in NodeRequestHandler#1156
Open
raju-opti wants to merge 2 commits into
Open
[FSSDK-12759] fix content-length header in NodeRequestHandler#1156raju-opti wants to merge 2 commits into
raju-opti wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect Content-Length calculation in the Node RequestHandler by switching from UTF-16 code-unit length (string.length) to UTF-8 byte length (Buffer.byteLength), preventing request-body truncation for multi-byte payloads.
Changes:
- Compute
content-lengthusingBuffer.byteLength(data)instead ofdata.length. - Simplify request body sending by using
request.end(data)rather thanwrite()+end(). - Add integration-style tests that POST ASCII, emoji, and CJK JSON to a local HTTP server and assert the full body is received.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/utils/http_request_handler/request_handler.node.ts | Corrects Content-Length to use UTF-8 byte length and sends the body via request.end(data). |
| lib/utils/http_request_handler/request_handler.node.spec.ts | Adds regression tests using a real local HTTP server to validate multi-byte payloads aren’t truncated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues