ci: verify the repo brew and clone install from [v1.8.4] - #6
Merged
Merged
Conversation
This repository is what `brew install opsentry` and `git clone` pull from, and nothing verified it -- there were no workflows at all, only issue and PR templates. Every push and pull request now runs the 168-assertion hook suite, lints the Python, and syntax-checks install.sh plus all eight guardrail hooks so a broken installer cannot ship. The workflow is self-contained rather than calling the organisation's shared one, which lives in a private repository. A contributor opening a pull request must be able to read every step that gates it, and a private workflow would be invisible to them.
CI caught it on its first run: baseline.py and blocklog_audit.py carry #!/usr/bin/env python3 but were tracked 100644, so neither could be run directly despite advertising that it could. Both are invoked via python3 today, so the bit was cosmetic -- but a shebang that does not work is a claim the file does not honour, and fixing it is better than suppressing the check that found it. ruff is pinned in CI because its default rule set grows between releases, and an unpinned upgrade would fail a commit that changed nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository is what
brew install opsentryandgit cloneactually pull from — and nothing verified it. There were no workflows at all, only issue and PR templates.What now runs on every push and PR
ruff check opsentrybaseline.py,blocklog_audit.py)bash -noninstall.sh+ all 8 hooksinstall.shis the git-clone install path; a broken shebang there breaks the documented install for everyone not using brew or pip, and no test would otherwise catch itAll three verified locally first — 168 passed, ruff clean, every script parses.
Why it is self-contained
The rest of the organisation calls a reusable workflow from a private repository. This one does not, deliberately: a contributor opening a pull request must be able to read every step that gates it, and a private workflow would be invisible to them. It also avoids a public repository depending on a private one to verify itself.
Context
Part of making this repository the authoritative source for the free product. Related:
homebrew-opsentryv0.1.2 bumped the formula from a two-release-oldv1.8.0tarball tov1.8.3, sobrew installandgit clonenow agree.🤖 Generated with Claude Code