Repository navigation
Fix edge cases in propagation debug info. - #1664
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When propagation debug info is enabled, such as via --xla_dump_hlo_pass_re=shardy-verbose, several edge cases caused crashes, assertion failures or verifier errors. We need to handle null DataFlowEdgeOp because we don't create such an op for stablehlo.token in ManugalComputationOp. Fix lookUpValueOriginSharding to handle missing entry. Fix pushBackDictionaryToDebugInfo to correctly push empty debug info entries. Fix the verifier to handle multiple data-flow sources. PiperOrigin-RevId: 995956222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix edge cases in propagation debug info.
When propagation debug info is enabled, such as via --xla_dump_hlo_pass_re=shardy-verbose, several edge cases caused crashes, assertion failures or verifier errors.
We need to handle null DataFlowEdgeOp because we don't create such an op for stablehlo.token in ManugalComputationOp.
Fix lookUpValueOriginSharding to handle missing entry.
Fix pushBackDictionaryToDebugInfo to correctly push empty debug info entries.
Fix the verifier to handle multiple data-flow sources.