fixing exports in preprare llm models script#4340
Open
przepeck wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates prepare_llm_models.sh, which provisions a local model repository for OVMS LLM-related tests/demos, by adjusting how some tokenizers are obtained and by reordering the VLM preparation block.
Changes:
- Added a new model constant (
LFM25_MODEL). - Switched GEMMA4 tokenizer preparation from
hf download --include *tokenizer*toconvert_tokenizer --with_detokenizer. - Moved the VLM block later in the script and introduced an on-demand
typerupgrade before runninghf download.
Comment on lines
+226
to
+228
| pip3 install --upgrade typer==0.25.1 | ||
| hf download "$VLM_MODEL" --local-dir $1/$VLM_MODEL | ||
| convert_tokenizer OpenGVLab/InternVL2-1B --with_detokenizer -o $1/$VLM_MODEL # WA to use newer tokenizer model format which supports padding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-189149
Fixing prepare_llm_models.sh by changing order of exports and changing version of typer python lib.
🧪 Checklist
``