Skip to content

agrum3 - #106

Merged
jschueller merged 7 commits into
openturns:masterfrom
jschueller:agrum3
Jul 20, 2026
Merged

agrum3#106
jschueller merged 7 commits into
openturns:masterfrom
jschueller:agrum3

Conversation

@jschueller

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jschueller, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ca529caf-50be-4016-b4a2-4f60fbae80de

📥 Commits

Reviewing files that changed from the base of the PR and between f7a55c7 and e0df1db.

📒 Files selected for processing (53)
  • AUTHORS
  • CMakeLists.txt
  • VERSION
  • distro/debian/changelog
  • distro/rpm/otagrum.spec
  • lib/src/ContinuousBayesianNetworkFactory.cxx
  • lib/src/ContinuousMIIC.cxx
  • lib/src/ContinuousPC.cxx
  • lib/src/ContinuousTTest.cxx
  • lib/src/CorrectedMutualInformation.cxx
  • lib/src/Greater.cxx
  • lib/src/JunctionTreeBernsteinCopula.cxx
  • lib/src/NamedDAG.cxx
  • lib/src/NamedJunctionTree.cxx
  • lib/src/TabuList.cxx
  • lib/src/Utils.cxx
  • lib/src/otagrum/ContinuousMIIC.hxx
  • lib/src/otagrum/CorrectedMutualInformation.hxx
  • lib/src/otagrum/Greater.hxx
  • lib/src/otagrum/NamedDAG.hxx
  • lib/src/otagrum/NamedJunctionTree.hxx
  • lib/src/otagrum/TabuList.hxx
  • lib/src/otagrum/Utils.hxx
  • lib/test/CMakeLists.txt
  • lib/test/t_ContinuousBayesianNetwork_std.cxx
  • lib/test/t_ContinuousBayesianNetwork_std.expout
  • lib/test/t_ContinuousPC_std.expout
  • lib/test/t_Greater_std.cxx
  • lib/test/t_Greater_std.expout
  • lib/test/t_JunctionTreeBernsteinCopulaFactory_std.cxx
  • lib/test/t_JunctionTreeBernsteinCopulaFactory_std.expout
  • lib/test/t_Utils_std.expout
  • python/src/ContinuousBayesianNetworkFactory_doc.i
  • python/src/NamedDAG.i
  • python/src/NamedDAG_doc.i
  • python/src/__init__.py
  • python/src/otagrum_agrum.i
  • python/test/CMakeLists.txt
  • python/test/t_ContinuousMIIC_std.expout
  • python/test/t_ContinuousMIIC_std.py
  • python/test/t_ContinuousPC_std.expout
  • python/test/t_ContinuousPC_std.py
  • python/test/t_ContinuousTTest_std.expout
  • python/test/t_ContinuousTTest_std.py
  • python/test/t_CorrectedMutualInformation_std.expout
  • python/test/t_CorrectedMutualInformation_std.py
  • python/test/t_JunctionTreeBernsteinCopulaFactory_std.expout
  • python/test/t_JunctionTreeBernsteinCopulaFactory_std.py
  • python/test/t_NamedDAG_std.expout
  • python/test/t_NamedDAG_std.py
  • python/test/t_TabuList_std.py
  • python/test/t_Utils_std.expout
  • python/test/t_Utils_std.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

phwuil and others added 7 commits July 20, 2026 14:46
- CMakeLists.txt: require aGrUM >= 3, find OpenMP
- Drop unused NamedDAG.hxx include from CorrectedMutualInformation.hxx
- Clarify NamedJunctionTree's variable-id vs clique-id name mapping
- Refactor NamedDAG.cxx and TabuList.cxx
- Update expected test outputs accordingly
- Add detailed code audit (audit.md)
- JunctionTreeBernsteinCopula::setBinNumber() now recomputes cached state
- NamedJunctionTree: replace assert() with an exception (release-safe)
- Fix stale ResourceMap key name in factory docstring
- Fix copy-pasted SWIG file header comment
- Document the SWIG warning-suppression pragma
…pointers

- Share namesFromData/idFromName/learnDAG/GetK via Utils across
  ContinuousPC, ContinuousMIIC and TabuList
- Extract recordLatentCoupleIfNeeded() and legalChangesForPair() to
  remove duplicated blocks in ContinuousMIIC/TabuList
- Reject empty samples in ContinuousTTest/CorrectedMutualInformation
  instead of silently propagating NaN
- Reject TabuList(restarts=0) instead of underflowing
- Wrap rank_'s shared_ptr<tuple<...>> in a RankedTriple class with
  named accessors (gum::Heap requires copyable elements, so
  unique_ptr is not an option)
- Add license/OTAGRUM_API to Greater.hxx, document why DeriveDAG is
  hidden from SWIG
- Add C++ tests for Greater and JunctionTreeBernsteinCopulaFactory
- Add Python tests for ContinuousTTest, CorrectedMutualInformation,
  NamedDAG and JunctionTreeBernsteinCopulaFactory
- Reactivate disabled Utils.py tests and ContinuousBayesianNetwork's
  genereData()
- Add empty-sample/invalid-input exception checks to ContinuousPC,
  ContinuousMIIC and TabuList Python tests
agrum's BIFReader.h/BIFWriter.h pull in <windows.h> on mingw, which
#defines GetClassName to GetClassNameA/W. In unity builds this leaks
into later translation units (e.g. NamedDAG.cxx), breaking OT's
CLASSNAMEINIT macro whose declaration/definition then mismatch.
@jschueller
jschueller marked this pull request as ready for review July 20, 2026 13:09
@jschueller
jschueller merged commit ed3a93c into openturns:master Jul 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants