Repository navigation
Strict Mode: Transit Vehicle Overlay - #962
daniel-heppner-ibigroup wants to merge 9 commits into
Conversation
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
miles-grant-ibigroup
|
gotta fix the type error here |
cea8264 to
fd7e5e6
Compare
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Seems to be working well
| autoOffset={iconPixels / 2 + iconPadding + 4} | ||
| popupProps={{ | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore why is this required? Is it some pnpm packaging issue? |
There was a problem hiding this comment.
Do we want to address this
There was a problem hiding this comment.
good point... after playing with this in the storybook I think this parameter actually doesn't do anything at all. the typescript error was right
There was a problem hiding this comment.
I'm just gonna remove it
There was a problem hiding this comment.
MarkerWithProps is defined in base-map and popupProps is definitely used...
There was a problem hiding this comment.
I saw that, but it's just passed through the the maplibre component which doesn't seem to consume it. I played with some of the options we pass into it and it doesn't seem to change the output at all.
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
daniel-heppner-ibigroup
assigned
binh-dam-ibigroup and unassigned
daniel-heppner-ibigroup
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Not comfortable removing popupProps
binh-dam-ibigroup
assigned
daniel-heppner-ibigroup and
binh-dam-ibigroup and unassigned
binh-dam-ibigroup
|
update here: the padding option was not supported in our version of maplibre, however the newer versions do support it. I updated maplibre and restored the padding option. so I wonder if at some point we had been using a newer version, or maybe OTP-RR has a newer version? anyway, it's restored now. |
95e3b0d to
6c59c22
Compare
daniel-heppner-ibigroup
assigned
miles-grant-ibigroup and unassigned
daniel-heppner-ibigroup
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Do we need a new major version for transit-vehicle-overlay?
| vehicle.lon && ( | ||
| <MarkerWithPopup | ||
| key={vehicle.vehicleId} | ||
| autoOffset={iconPixels / 2 + iconPadding + 4} |
There was a problem hiding this comment.
Nit - sort props
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Please advise regarding the breaking change, and address merge conflicts.
33851dd to
875c651
Compare
- Enable TypeScript strict mode - Improve type annotations - Clean up styled components
daniel-heppner-ibigroup
assigned
binh-dam-ibigroup and unassigned
daniel-heppner-ibigroup
875c651 to
9e8e397
Compare
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Thank you for the changes
This branch has not been deployed
4 participants
pretty straightforward one here