OCM-00000 | ci: Update aws-sdk#3272
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
The updated IAM ListRoles paginator passes functional options as a third argument; update gomock expectations to match the aws-sdk-go-v2 v1.54.x API. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (297)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3272 +/- ##
==========================================
+ Coverage 25.00% 26.17% +1.17%
==========================================
Files 330 334 +4
Lines 36162 36704 +542
==========================================
+ Hits 9042 9608 +566
+ Misses 26458 26359 -99
- Partials 662 737 +75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PR Summary
Supersedes Konflux mintmaker PR #3260 by bumping
aws-sdk-go-v2and related modules, and fixing unit test mock expectations broken by the updated IAMListRolespaginator API.Detailed Description of the Issue
Konflux PR #3260 updates
go.mod,go.sum, and vendor for a majoraws-sdk-go-v2bump but failsci/prow/test. The new IAMListRolespaginator passes functional options as a third argument toListRoles; existing gomock expectations inpkg/awsonly matched two arguments, causing threeListOperatorRolestests to fail.Related Issues and PRs
Type of Change
Previous Behavior
CI tests pass on
masterwith olderaws-sdk-go-v2modules. Mintmaker PR #3260 bumps AWS SDK dependencies but failspkg/awstests becauseListRolesmock expectations do not accept the paginator's third functional-options argument.Behavior After This Change
AWS SDK dependencies are updated to the mintmaker versions and
pkg/awstests expect the three-argumentListRolessignature.make testandmake lintpass locally. No CLI behavior changes.How to Test (Step-by-Step)
Preconditions
Test Steps
make testmake lintExpected Results
All unit tests pass and lint reports 0 issues.
Proof of the Fix
Breaking Changes
Breaking Change Details / Migration Plan
N/A
Developer Verification Checklist
[JIRA-TICKET] | [TYPE]: <MESSAGE>.make install-hookshas been run in this clone.make testpasses.make lintpasses.make rosapasses.Made with Cursor
Summary by CodeRabbit