OCM-00000 | ci: Update bingo-tooling#3261
Conversation
red-hat-konflux
Bot
added
the
ok-to-test
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThree bingo-managed Go tool module files are updated with version bumps: 🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/bingo-tooling
branch
2 times, most recently
from
e867eb6 to
d08cba7
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/bingo-tooling
branch
from
d08cba7 to
478deb3
Compare
red-hat-konflux
Bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.bingo/gci.mod:
- Line 5: Update the gci version references in `.bingo/Variables.mk` and
`.bingo/variables.env` to match the version bump in `.bingo/gci.mod`. Replace
all occurrences of gci-v0.13.4 with gci-v0.14.0 in both files to ensure
consistency across the bingo tool configuration. This will prevent stale tool
resolution issues in downstream scripts like hack/fmt.sh that depend on the
GCI_BIN variable.
In @.bingo/golangci-lint.mod:
- Line 5: The golangci-lint version in .bingo/golangci-lint.mod has been bumped
to v2.12.2, but the version suffix references in .bingo/Variables.mk (lines
38-42 containing golangci-lint-v2.11.4) and .bingo/variables.env (lines 15-18
containing golangci-lint-v2.11.4) still point to the old v2.11.4. Update all
occurrences of golangci-lint-v2.11.4 to golangci-lint-v2.12.2 in both files to
maintain consistency across the tooling configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4562ae7b-22f2-4c6e-a868-73ed63def4fa
📒 Files selected for processing (2)
.bingo/gci.mod.bingo/golangci-lint.mod
| go 1.25.8 | ||
|
|
||
| require github.com/daixiang0/gci v0.13.4 | ||
| require github.com/daixiang0/gci v0.14.0 |
There was a problem hiding this comment.
Synchronize gci binary path/version constants with this pin bump.
Line 5 updates gci to v0.14.0, but .bingo/Variables.mk (Lines 26-30 in provided snippet) and .bingo/variables.env (Lines 11-14) still point to gci-v0.13.4. That leaves the bingo tool contract inconsistent and can cause stale/misleading tool resolution in downstream scripts (for example, hack/fmt.sh via GCI_BIN).
Proposed follow-up edits
- GCI := $(GOBIN)/gci-v0.13.4
+ GCI := $(GOBIN)/gci-v0.14.0
...
- `@echo` "(re)installing $(GOBIN)/gci-v0.13.4"
- `@cd` $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=gci.mod -o=$(GOBIN)/gci-v0.13.4 "github.com/daixiang0/gci"
+ `@echo` "(re)installing $(GOBIN)/gci-v0.14.0"
+ `@cd` $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=gci.mod -o=$(GOBIN)/gci-v0.14.0 "github.com/daixiang0/gci"- GCI="${GOBIN}/gci-v0.13.4"
+ GCI="${GOBIN}/gci-v0.14.0"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.bingo/gci.mod at line 5, Update the gci version references in
`.bingo/Variables.mk` and `.bingo/variables.env` to match the version bump in
`.bingo/gci.mod`. Replace all occurrences of gci-v0.13.4 with gci-v0.14.0 in
both files to ensure consistency across the bingo tool configuration. This will
prevent stale tool resolution issues in downstream scripts like hack/fmt.sh that
depend on the GCI_BIN variable.
| go 1.25.8 | ||
|
|
||
| require github.com/golangci/golangci-lint/v2 v2.11.4 // cmd/golangci-lint | ||
| require github.com/golangci/golangci-lint/v2 v2.12.2 // cmd/golangci-lint |
There was a problem hiding this comment.
Update bingo’s golangci-lint binary/env version suffixes to match v2.12.2.
Line 5 bumps golangci-lint to v2.12.2, but .bingo/Variables.mk (Lines 38-42 in provided snippet) and .bingo/variables.env (Lines 15-18) still use golangci-lint-v2.11.4. This mismatch breaks the cross-file tooling contract and can leave lint invocations bound to stale or misnamed binaries.
Proposed follow-up edits
- GOLANGCI_LINT := $(GOBIN)/golangci-lint-v2.11.4
+ GOLANGCI_LINT := $(GOBIN)/golangci-lint-v2.12.2
...
- `@echo` "(re)installing $(GOBIN)/golangci-lint-v2.11.4"
- `@cd` $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=golangci-lint.mod -o=$(GOBIN)/golangci-lint-v2.11.4 "github.com/golangci/golangci-lint/v2/cmd/golangci-lint"
+ `@echo` "(re)installing $(GOBIN)/golangci-lint-v2.12.2"
+ `@cd` $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=golangci-lint.mod -o=$(GOBIN)/golangci-lint-v2.12.2 "github.com/golangci/golangci-lint/v2/cmd/golangci-lint"- GOLANGCI_LINT="${GOBIN}/golangci-lint-v2.11.4"
+ GOLANGCI_LINT="${GOBIN}/golangci-lint-v2.12.2"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.bingo/golangci-lint.mod at line 5, The golangci-lint version in
.bingo/golangci-lint.mod has been bumped to v2.12.2, but the version suffix
references in .bingo/Variables.mk (lines 38-42 containing golangci-lint-v2.11.4)
and .bingo/variables.env (lines 15-18 containing golangci-lint-v2.11.4) still
point to the old v2.11.4. Update all occurrences of golangci-lint-v2.11.4 to
golangci-lint-v2.12.2 in both files to maintain consistency across the tooling
configuration.
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/bingo-tooling
branch
from
478deb3 to
410deb6
Compare
This PR contains the following updates:
v0.9.0→v0.10.0v0.13.4→v0.14.0v2.11.4→v2.12.2Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
bwplotka/bingo (github.com/bwplotka/bingo)
v0.10.0Compare Source
What's Changed
New Contributors
Full Changelog: bwplotka/bingo@v0.9.0...v0.10.0
daixiang0/gci (github.com/daixiang0/gci)
v0.14.0Compare Source
AST Support is Coming!
See details in #241
Other Changes
New Contributors
Full Changelog: daixiang0/gci@v0.13.7...v0.14.0
v0.13.7Compare Source
What's Changed
New Contributors
Full Changelog: daixiang0/gci@v0.13.6...v0.13.7
v0.13.6Compare Source
What's Changed
Full Changelog: daixiang0/gci@v0.13.5...v0.13.6
v0.13.5Compare Source
What's Changed
New Contributors
Full Changelog: daixiang0/gci@v0.13.4...v0.13.5
golangci/golangci-lint (github.com/golangci/golangci-lint/v2)
v2.12.2Compare Source
Released on 2026-05-06
gomodguard_v2: fix blocked configurationgomodguard_v2: from 2.1.0 to 2.1.3iface: from 1.4.1 to 1.4.2v2.12.1Compare Source
Released on 2026-05-01
gomodguard_v2: fix panic with migration suggestioninstall.shscript (if you are still using an URL based on the branchmaster, please update to usehttps://golangci-lint.run/install.sh)v2.12.0Compare Source
Released on 2026-05-01
clickhouselintlinter https://github.com/ClickHouse/clickhouse-go-linterdupl: fromf665c8dtoc99c5cf(extended detection)funcorder: from 0.5.0 to 0.6.0 (new option:function)goconst: add an option to ignore strings from testsgoconst: from 1.8.2 to 1.10.0 (extended detection)gomodguard_v2: from 1.4.1 to 2.1.0 (major version with new configuration)gosec: from619ce21to 2.26.1 (new checks:G124,G708,G709,G710)govet: addinlineanalyzermakezero: from 2.1.0 to 2.2.1 (support slice type aliases)paralleltest: exposecheckcleanupoptionsloglint: from 0.11.1 to 0.12.0 (new options:allowed-keys,custom-funcs)wsl_v5: from 5.6.0 to 5.8.0 (new option:cuddle-max-statements; new checks:after-decl,after-defer,after-expr,after-go,cuddle-group)forbidigo: from 2.3.0 to 2.3.1godot: from 1.5.4 to 1.5.6govet-modernize: from 0.43.0 to 0.44.0ireturn: from 0.4.0 to 0.4.1rowserrcheck: from 1.1.1 toc5f79b8customcommandConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.
Summary by CodeRabbit