NO-JIRA: perses-dev with 6th user

[etmurasaki]

Summary by CodeRabbit

This PR updates the test configuration for the OpenShift Monitoring Plugin's Perses dev UI testing. Specifically, it increases the number of test users generated for the Cypress E2E test suite from 5 to 6 users.

The change modifies a step registry script that generates htpasswd and IDP users for CI tests. By adjusting the user-generation loop to iterate from 1 to 6 instead of 1 to 5, the resulting CYPRESS_LOGIN_USERS environment variable will now include an additional test user credential. This allows the monitoring plugin's Perses dev UI tests to run with an expanded set of test accounts.

[openshift-ci-robot]

@etmurasaki: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/monitoring-plugin/tests/perses-dev-ui/OWNERS [etmurasaki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 208ffcd4-35ae-4214-ab83-8e4f9778ec7e

📥 Commits

Reviewing files that changed from the base of the PR and between f71d69d and ce2db99.

📒 Files selected for processing (1)

• ci-operator/step-registry/monitoring-plugin/tests/perses-dev-ui/monitoring-plugin-tests-perses-dev-ui-commands.sh

---

Walkthrough

The seq loop upper bound in the perses-dev-ui test script's user-preparation section is incremented from 5 to 6, causing one additional htpasswd user to be generated and included in CYPRESS_LOGIN_USERS.

Changes

User Generation Loop

Layer / File(s)	Summary
Increment seq loop bound to 6 ci-operator/step-registry/monitoring-plugin/tests/perses-dev-ui/monitoring-plugin-tests-perses-dev-ui-commands.sh	The seq 1 5 loop is changed to seq 1 6, generating one extra htpasswd/IDP user appended to CYPRESS_LOGIN_USERS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a sixth user to the perses-dev configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies a bash test setup script, not a Ginkgo test file. The change adds a 6th test user by updating a loop from 1-5 to 1-6. No Ginkgo test names (It, Describe, Context, When) exist in thi...
Test Structure And Quality	✅ Passed	The custom check reviews Ginkgo test code quality, but this PR only modifies a bash shell script (ci-operator/.../perses-dev-ui-commands.sh) that adds a 6th test user. No Ginkgo test files are modi...
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The change only modifies a shell script to create an additional HTPasswd/IDP user (iterating from 1-6 instead of 1-5). The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; it only modifies a shell script that sets up test user infrastructure for Cypress tests. SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes only a bash CI test script that generates test users; contains no deployment manifests, operator code, controllers, or scheduling constraints in scope of check.
Ote Binary Stdout Contract	✅ Passed	PR modifies only a shell script for CI test infrastructure setup, not an OTE binary. The OTE Binary Stdout Contract check applies only to Go binaries with process-level code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests. It modifies a bash script to add a 6th test user. Check is only applicable to new Ginkgo tests, not infrastructure/setup changes.
No-Weak-Crypto	✅ Passed	No weak crypto patterns detected. Script uses bcrypt (-B flag) for password hashing, which is modern and secure. Password generation uses /dev/urandom. Only change is adding one more test user.
Container-Privileges	✅ Passed	PR modifies only a test script that creates an additional test user (from 5 to 6). The test step ref.yaml and commands.sh contain no container privilege escalation directives: no privileged: true,...
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive data (passwords, tokens, credentials) is logged in this change. The script only increases user generation from 5 to 6 users; passwords are never echoed/printed, only stored in environm...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@etmurasaki: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-monitoring-plugin-main-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-5.1-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-5.0-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-4.23-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-4.22-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-coo-0.5-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-coo-ocp-4.19-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
pull-ci-openshift-monitoring-plugin-release-coo-ocp-4.22-e2e-perses-dev	openshift/monitoring-plugin	presubmit	Registry content changed
periodic-ci-openshift-monitoring-plugin-main-periodics-e2e-perses-dev	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@etmurasaki: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.