Skip to content

Increase the shard for 5.0 MCO AWS Longduration jobs #80795

Open
ptalgulk01 wants to merge 1 commit into
openshift:mainfrom
ptalgulk01:mco-shard
Open

Increase the shard for 5.0 MCO AWS Longduration jobs #80795
ptalgulk01 wants to merge 1 commit into
openshift:mainfrom
ptalgulk01:mco-shard

Conversation

@ptalgulk01

@ptalgulk01 ptalgulk01 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Increasing the CI job for MCO, so that MCO Longduraion AWS , does not timeout.

Summary by CodeRabbit

This PR updates the Machine Config Operator's 5.0 release branch CI configuration to increase parallelism for the e2e-aws-mco-fips-proxy-longduration periodic job. The shard_count is increased from 2 to 3, allowing the job to execute across three parallel shards instead of two.

This change brings the 5.0 release branch in line with the configuration already in place for the 4.22 and 4.23 release branches. The affected job is a weekly (168-hour interval) long-running test that validates Machine Config Operator functionality with FIPS enabled on AWS. By distributing the workload across an additional shard, the job can complete test execution more efficiently and avoid timeout issues that were previously occurring.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 04bd7987-3d20-4bec-a1bc-c6fb85e524ef

📥 Commits

Reviewing files that changed from the base of the PR and between 305ddb8 and 8511a71.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml

Walkthrough

The shard_count for the e2e-aws-mco-fips-proxy-longduration periodic job in the MCO release-5.0 periodics configuration is increased from 2 to 3. No other fields or jobs are modified.

Changes

MCO Periodics Config — Shard Count Update

Layer / File(s) Summary
shard_count bump for e2e-aws-mco-fips-proxy-longduration
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml
shard_count for the e2e-aws-mco-fips-proxy-longduration job is updated from 2 to 3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#80468: Makes the identical change — increasing shard_count from 2 to 3 for the e2e-aws-mco-fips-proxy-longduration periodic job in the same MCO periodics YAML file.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • umohnani8
  • dkhater-redhat
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: increasing shard allocation for 5.0 MCO AWS Longduration jobs, which matches the changeset that increases shard_count from 2 to 3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration (shard_count parameter in YAML), not Ginkgo test code. No test titles or dynamic test names present.
Test Structure And Quality ✅ Passed PR changes only a CI configuration YAML file (adjusting job shard count), not test code. The check for Ginkgo test quality is not applicable to configuration files.
Microshift Test Compatibility ✅ Passed PR only modifies CI configuration (increases shard_count), not Ginkgo test code. Check applies only when new e2e tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests (It(), Describe(), etc.) are added in this PR. The change only modifies CI configuration files to increase shard_count for an existing job, making the SNO compatibility chec...
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a CI/Prow job configuration file (shard_count for a periodic test job), not deployment manifests, operator code, or controllers. It introduces no Kubernetes scheduling constraints...
Ote Binary Stdout Contract ✅ Passed PR only modifies a YAML CI config file (shard_count change), not any Go/test code. The OTE Binary Stdout Contract check applies only to test binary code, not CI configuration.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies a CI configuration YAML file (openshift-machine-config-operator-release-5.0__periodics.yaml) to increase the shard_count of an existi...
No-Weak-Crypto ✅ Passed PR modifies only CI configuration (shard_count: 2→3), not source code. No cryptographic code, weak crypto algorithms, or custom crypto implementations present.
Container-Privileges ✅ Passed The PR modifies only a CI operator job configuration file (shard_count change), not container/K8s security manifests. No privileged settings, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscala...
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes shard_count from 2 to 3 in a CI configuration file. No passwords, tokens, API keys, PII, session IDs, or sensitive customer data are exposed in the changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from proietfb and umohnani8 June 19, 2026 15:37
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ptalgulk01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ptalgulk01: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-machine-config-operator-release-5.0-periodics-e2e-aws-mco-fips-proxy-longduration-3of3 N/A periodic Periodic changed
periodic-ci-openshift-machine-config-operator-release-5.0-periodics-e2e-aws-mco-fips-proxy-longduration-1of3 N/A periodic Periodic changed
periodic-ci-openshift-machine-config-operator-release-5.0-periodics-e2e-aws-mco-fips-proxy-longduration-2of3 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@ptalgulk01: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant