Skip to content

ARO-HCP: Bump shard01 e2e slots to 6#80793

Open
roivaz wants to merge 1 commit into
openshift:mainfrom
roivaz:bump-shard1-e2e-slots
Open

ARO-HCP: Bump shard01 e2e slots to 6#80793
roivaz wants to merge 1 commit into
openshift:mainfrom
roivaz:bump-shard1-e2e-slots

Conversation

@roivaz

@roivaz roivaz commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/ARO-27242

Depends on Azure/ARO-HCP#5728

/hold

Summary by CodeRabbit

This PR increases the Azure Red Hat OpenShift Hosted Control Plane (ARO-HCP) development e2e testing capacity by expanding the BOSKOS resource pools in the OpenShift CI infrastructure.

Infrastructure Changes:

  • Increases aro-hcp-dev-shard1-slot resources from 3 to 6 slots for e2e testing
  • Adds a new resource pool aro-hcp-dev-hypershift-westus3-slot with 1 slot for the westus3 region

Files Modified:

  • core-services/prow/02_config/_boskos.yaml: Manually extends the BOSKOS quota slice configuration with 3 additional shard1 slots and introduces the new westus3 hypershift slot
  • core-services/prow/02_config/generate-boskos.py: Updates the generator script to dynamically create 6 shard1 slots (instead of 3) and adds generation of the new westus3 hypershift slot

These changes scale up the e2e test parallelization capacity for ARO-HCP development, enabling faster CI feedback for the ARO-HCP team. The PR is currently on hold pending upstream coordination with Azure/ARO-HCP repository.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 90774aba-c432-4123-8280-0abf4698dd53

📥 Commits

Reviewing files that changed from the base of the PR and between 026d9c3 and d5bff92.

📒 Files selected for processing (2)
  • core-services/prow/02_config/_boskos.yaml
  • core-services/prow/02_config/generate-boskos.py

Walkthrough

Adds a new Boskos resource type aro-hcp-dev-hypershift-westus3-slot (1 slot) and expands aro-hcp-dev-shard1-slot from 3 to 6 entries. Changes are made in both the generator script (generate-boskos.py) and the generated output (_boskos.yaml).

Changes

ARO HCP Boskos Slot Expansion

Layer / File(s) Summary
Generator script: CONFIG entry and slot generation loops
core-services/prow/02_config/generate-boskos.py
Adds aro-hcp-dev-hypershift-westus3-slot to the CONFIG map and updates the E2E slot generation block to emit 6 shard1-slot-* names (range(6) instead of range(3)) and 1 hypershift-westus3-slot-* name.
Generated YAML: new slot type and expanded shard1 names
core-services/prow/02_config/_boskos.yaml
Inserts a new resource block for aro-hcp-dev-hypershift-westus3-slot-00 and appends shard1-slot-03 through shard1-slot-05 to the existing aro-hcp-dev-shard1-slot entry, both with state: free.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#80465: Extends the same _boskos.yaml and generate-boskos.py files by adding new ARO-HCP E2E slot resource types and wiring them into the same Boskos CONFIG/resource-population logic.
  • openshift/release#80714: Modifies the same generate-boskos.py and _boskos.yaml files to change the generated Boskos quota-slice resource sets for aro-hcp-dev shard slots.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • smg247
  • deepsm007
  • raelga
  • janboll
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ARO-HCP: Bump shard01 e2e slots to 6' accurately describes the main change in the changeset, which increases e2e slot resources for aro-hcp-dev-shard1-slot from 3 to 6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo test files; only YAML configuration and Python utility script changes related to Boskos resource management.
Test Structure And Quality ✅ Passed Pull request contains only configuration files and a Python generation script, not Ginkgo test code. Custom check is inapplicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The changes only modify BOSKOS configuration files and a Python script that generates resource quotas for CI infrastructure, not e2e test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only modifies infrastructure configuration files (_boskos.yaml and generate-boskos.py) for test resource quota allocation, not test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes are test infrastructure resource allocation config (BOSKOS), not deployment manifests or operator code with scheduling constraints. No topology-aware scheduling issues apply.
Ote Binary Stdout Contract ✅ Passed This PR modifies only BOSKOS configuration files (_boskos.yaml) and a Python generation script, not OTE test binaries. The check is inapplicable to infrastructure configuration changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to Boskos configuration files and a Python script for generating resource quotas—not test implementations.
No-Weak-Crypto ✅ Passed PR contains only infrastructure configuration files with no cryptographic code, weak algorithms, or insecure secret comparisons detected.
Container-Privileges ✅ Passed PR modifies only configuration generation scripts and resource quota files, not container/K8s manifests. No privileged container settings found in any modified files.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data exposure found. Changes contain only resource names, region identifiers, and counts. No credentials, tokens, PII, or internal secrets are logged or written.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from droslean and psalajova June 19, 2026 14:46
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roivaz
Once this PR has been reviewed and has the lgtm label, please assign hector-vido for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 19, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@roivaz: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@roivaz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant