Skip to content

Add extra job to openstack-operator for testing 4.20#80790

Open
bshewale wants to merge 1 commit into
openshift:mainfrom
bshewale:4.20_p1
Open

Add extra job to openstack-operator for testing 4.20#80790
bshewale wants to merge 1 commit into
openshift:mainfrom
bshewale:4.20_p1

Conversation

@bshewale

@bshewale bshewale commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR adds a new CI testing job for the OpenStack Operator component to validate compatibility with OpenShift 4.20. Specifically, it introduces the openstack-operator-build-deploy-kuttl-4-20 job in the test matrix for the openstack-operator repository's CI configuration.

The new job follows the existing KUTTL (KUnit Test Library) build and deploy testing pattern already used for other OpenShift versions, using the openstack-k8s-operators-test-build-deploy-kuttl workflow. The job is configured with CEPH_HOSTNETWORK: "false" for its test environment.

This extends the CI infrastructure to test OpenStack Operator against the upcoming OpenShift 4.20 release, complementing the existing 4.18 KUTTL test job and ensuring the operator is validated across multiple OpenShift versions during development.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e9e78d92-18e3-4608-bc78-f9e4e6f85cdd

📥 Commits

Reviewing files that changed from the base of the PR and between ba463cb and 3b6d7c5.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openstack-k8s-operators/openstack-operator/openstack-k8s-operators-openstack-operator-18.0-fr5-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openstack-k8s-operators/openstack-operator/openstack-k8s-operators-openstack-operator-18.0-fr5.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openstack-k8s-operators/openstack-operator/openstack-k8s-operators-openstack-operator-18.0-fr5.yaml

Walkthrough

A new CI test job openstack-operator-build-deploy-kuttl-4-20 is added to the tests matrix in the openstack-operator 18.0-fr5 CI config. It mirrors the existing 4.18 KUTTL job but claims an OCP 4.20 cluster and sets CEPH_HOSTNETWORK: "false".

Changes

OCP 4.20 KUTTL CI Job

Layer / File(s) Summary
New KUTTL 4.20 test job
ci-operator/config/openstack-k8s-operators/openstack-operator/openstack-k8s-operators-openstack-operator-18.0-fr5.yaml
Adds openstack-operator-build-deploy-kuttl-4-20 to the tests matrix with a cluster_claim for ocp product version 4.20, CEPH_HOSTNETWORK: "false" in steps env, and the openstack-k8s-operators-test-build-deploy-kuttl workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add extra job to openstack-operator for testing 4.20' directly and accurately describes the main change: adding a new CI job for OpenShift 4.20 testing to the openstack-operator configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI config only, not Ginkgo test code. Check for stable test names is not applicable to CI job identifiers in YAML configuration files.
Test Structure And Quality ✅ Passed PR modifies only CI configuration files (YAML) with no Ginkgo test code changes. The custom check for "Test Structure and Quality" is not applicable to CI/CD configuration changes.
Microshift Test Compatibility ✅ Passed The PR adds only a CI job configuration entry, not new Ginkgo e2e tests. The custom check applies only when new tests with patterns like It(), Describe(), etc. are added. This PR is inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added; PR only modifies CI configuration YAML to add a job for testing on OCP 4.20, which is outside the scope of SNO compatibility checks for test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds CI job configuration for testing on OCP 4.20, not deployment manifests, operator code, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI configuration YAML files, not source code. The OTE Binary Stdout Contract check applies only to code-level violations in main(), init(), logging setup, etc., which do not exist...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies CI job configuration YAML files and does not add any new Ginkgo e2e test code, so the IPv6/disconnected network check is not applicable.
No-Weak-Crypto ✅ Passed PR adds CI configuration for OpenStack 4.20 testing; only YAML modification with no cryptographic code, weak crypto algorithms, or insecure comparisons present.
Container-Privileges ✅ Passed PR adds a new CI job for OpenStack operator testing. No privileged container settings (privileged: true, hostPID, hostNetwork: true, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, root without...
No-Sensitive-Data-In-Logs ✅ Passed The PR adds a new CI job for OpenStack operator 4.20 testing. No sensitive data (passwords, tokens, API keys, PII, session IDs, hostnames, or customer data) is exposed in the configuration, command...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from abays and rebtoor June 19, 2026 12:43
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bshewale
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bshewale: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-openstack-operator-18.0-fr5-openstack-operator-build-deploy-kuttl-4-20 openstack-k8s-operators/openstack-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bshewale

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-operator-18.0-fr5-openstack-operator-build-deploy-kuttl-4-20

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bshewale: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@bshewale: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openstack-k8s-operators/openstack-operator/18.0-fr5/openstack-operator-build-deploy-kuttl-4-20 3b6d7c5 link unknown /pj-rehearse pull-ci-openstack-k8s-operators-openstack-operator-18.0-fr5-openstack-operator-build-deploy-kuttl-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant