Skip to content

add oc-mirror to extensionBinaries#31006

Draft
adolfo-ab wants to merge 1 commit intoopenshift:mainfrom
adolfo-ab:ote-oc-mirror
Draft

add oc-mirror to extensionBinaries#31006
adolfo-ab wants to merge 1 commit intoopenshift:mainfrom
adolfo-ab:ote-oc-mirror

Conversation

@adolfo-ab
Copy link
Copy Markdown

@adolfo-ab adolfo-ab commented Apr 14, 2026

Summary by CodeRabbit

  • Tests
    • Expanded extension testing support by adding an additional external test binary ("oc-mirror"), enabling discovery, extraction, listing, and execution of more extension tests for validation and verification.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ca1cbe92-f3b7-4fd1-8f13-d06c33300461

📥 Commits

Reviewing files that changed from the base of the PR and between 8d1f099 and 7dcf4a2.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/test/extensions/binary.go

Walkthrough

Added a new test binary entry to the extension binaries registry in test utilities: imageTag "oc-mirror" with binaryPath "/usr/bin/oc-mirror-tests-ext.gz". No other logic, control flow, or error handling was changed.

Changes

Cohort / File(s) Summary
Extension Test Binary Configuration
pkg/test/extensions/binary.go
Appended a new TestBinary entry to extensionBinaries with imageTag: "oc-mirror" and binaryPath: "/usr/bin/oc-mirror-tests-ext.gz" for external extension testing discovery and extraction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive Unable to locate PR changes or relevant test files to assess Ginkgo test name stability and determinism requirements. Provide access to the PR changes, specific file paths, or git diff output to perform the assessment.
Ote Binary Stdout Contract ❓ Inconclusive The PR adds a reference to an external OTE binary (oc-mirror-tests-ext.gz) in the extensionBinaries registry. The actual binary implementation resides outside this repository and cannot be inspected within the codebase to verify OTE stdout contract compliance. Examine the actual oc-mirror test extension binary code to confirm it does not write non-JSON data to stdout and that klog is configured to write to stderr via klog.SetOutput(os.Stderr) or similar.
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the primary change: adding 'oc-mirror' to the 'extensionBinaries' registry entry, which matches the changeset exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Structure And Quality ✅ Passed The PR modifies only configuration data in the extensionBinaries registry, not Ginkgo test code, making the Test Structure and Quality check inapplicable.
Microshift Test Compatibility ✅ Passed This PR only registers an external test binary source without defining any Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR only adds a configuration entry to register an external test binary in the extension framework registry, not new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed This PR is not applicable to the Topology-Aware Scheduling Compatibility check. The change only updates test infrastructure code without involving scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only a configuration entry to the extensionBinaries registry and does not add any new Ginkgo e2e tests, so the custom check for IPv4 assumptions in new tests does not apply.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adolfo-ab
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7c82a9e0-37f1-11f1-8f47-552584c66ffc-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3268a3e0-38c4-11f1-8097-e51627f73738-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc7638b0-38d9-11f1-8041-6bf03a0e77d4-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 16, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5710bbd0-3999-11f1-8b65-54119c798fb5-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant