Skip to content

[main] Tests: Fix failure to dismiss guided tour when running locally#2123

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
openshift-cherrypick-robot:cherry-pick-2118-to-main
Jun 23, 2026
Merged

[main] Tests: Fix failure to dismiss guided tour when running locally#2123
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
openshift-cherrypick-robot:cherry-pick-2118-to-main

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 22, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #2118

/assign kyoto

Summary by CodeRabbit

  • Tests
    • Updated test fixtures to automatically dismiss the guided tour during test runs, improving test reliability.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 15b1d6a1-e65a-49b0-b95f-12340460f197

📥 Commits

Reviewing files that changed from the base of the PR and between 6164813 and 2dcdabc.

📒 Files selected for processing (1)
  • tests/support/fixtures.ts

📝 Walkthrough

Walkthrough

A new auto-applied Playwright fixture dismissGuidedTour is added to the shared test base in tests/support/fixtures.ts. It registers a locator handler that clicks the guided tour footer secondary button whenever it appears, preventing it from blocking test execution.

Changes

Guided Tour Dismissal Fixture

Layer / File(s) Summary
dismissGuidedTour auto fixture
tests/support/fixtures.ts
Extends the test export's fixture type to include dismissGuidedTour: void and implements it as an auto fixture using page.addLocatorHandler to click the guided tour footer secondary button before proceeding with use().

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/lightspeed-console#2118: Directly related — the same dismissGuidedTour auto fixture and tests/support/fixtures.ts extension are the subject of both PRs.

Suggested labels

lgtm, approved

🐇 A tour popped up mid-test one day,
Blocking the clicks in a stubborn way.
So I added a handler, swift and neat,
To click it away and admit defeat.
Now tests run free — hip hip hooray! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a dismissGuidedTour fixture to fix test failures related to guided tour dismissal when running tests locally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from JoaoFula and xrajesh June 22, 2026 10:03
@kyoto

kyoto commented Jun 23, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit dc24432 into openshift:main Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants