Repository navigation
MigratePoolingNHttpClientConnectionManager removes the imports it leaves unused - #160
Merged
Merged
Conversation
…ves unused The builder replacement drops the constructor's arguments, so a type named only there, such as DefaultConnectingIOReactor in new PoolingNHttpClientConnectionManager(new DefaultConnectingIOReactor()), kept an import nothing used. Schedule maybeRemoveImport for each type the arguments name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main went red on https://github.com/openrewrite/rewrite-apache/actions/runs/40046607973 after the rewrite snapshot carrying openrewrite/rewrite#9375, which fails a
rewriteRunwhose recipe output imports something nothing in the file uses.MigratePoolingNHttpClientConnectionManagerTest > migratesSimpleConstructor()reported:The recipe replaces
new PoolingNHttpClientConnectionManager(new DefaultConnectingIOReactor())withPoolingAsyncClientConnectionManagerBuilder.create().build(), which drops the constructor's arguments. That argument was the file's only use ofDefaultConnectingIOReactor, so its import stayed behind.visitNewClassnow schedulesmaybeRemoveImportfor every type the dropped arguments name.RemoveImportkeeps an import the file still names, so an argument that is a variable, as in the other tests, keeps its type's import. The test'safterhad pinned the leftover import and now omits it.