Conversation
Contributor
|
We clould run all the test cases. |
u5surf
force-pushed
the
ci-asan-job
branch
6 times, most recently
from
September 17, 2026 01:48
198738a to
8232eda
Compare
Contributor
Author
|
@zhuizhuhaomeng Done — the job now runs the whole suite.
The remaining red job is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an AddressSanitizer job that runs the whole test suite. Following @zhuizhuhaomeng's note that we could run all the test cases, this covers everything rather than a socket subset.
The key part is building LuaJIT with
LUAJIT_USE_SYSMALLOC: without it, LuaJIT's allocator never returns memory to the C allocator, so ASan cannot see use-after-free on Lua objects at all.What the job does
NGX_BUILD_ASAN=1, whichngx-buildalready supports, and LuaJIT withLUAJIT_USE_SYSMALLOC.t/065-tcp-socket-timeout.t,t/131-duplex-req-socket.t) put mockeagain inLD_PRELOADthemselves.TEST_NGINX_TIMEOUTthan the other jobs, since ASan slows every request down.asan-logs/on failure. An ASan abort otherwise surfaces only as a connection error from the test harness, which is hard to read.It finds real defects
Before #2525 landed, this job reported a heap-use-after-free in
t/067-req-socket.tTEST 20 — the existing regression test from #2504 — on unmodified master:That was #2517. With the fix merged, the job is clean.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.