fix(wacli): resolve group chat titles#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
untitledeven though wacli had the group name.ChatName/chatNamefrom newer webhook payloads and use a read-onlystore_dir/wacli.dblookup (chats, thengroups) as a legacy group-only fallback.Label Snapshot (required)
risk: low|medium|high): risk: lowsize: XS|S|M|L|XL, auto-managed/read-only): size: S expectedcore|agent|channel|config|cron|daemon|doctor|gateway|health|heartbeat|integration|memory|observability|onboard|provider|runtime|security|service|skillforge|skills|tool|tunnel|docs|dependencies|ci|tests|scripts|dev, comma-separated): channel, config, docs, tests<module>: <component>, for examplechannel: telegram,provider: kimi,tool: shell): channel: waclitrusted contributor|experienced contributor|principal contributor|distinguished contributor, auto-managed/read-only; author merged PRs >=5/10/20/50): auto-managedChange Metadata
bug|feature|refactor|docs|security|chore): bugruntime|provider|channel|memory|security|ci|docs|multi): channelLinked Issue
Supersede Attribution (required when
Supersedes #is used)#<pr> by @<author>, one per line): Not applicableCo-authored-bytrailers added for materially incorporated contributors? (Yes/No): NoNo, explain why (for example: inspiration-only, no direct code/design carry-over): No superseded or incorporated contribution\\n): PassValidation Evidence (required)
Commands and result summary:
Security Impact (required)
Yes/No): NoYes/No): NoYes/No): NoYes/No): YesYes, describe risk and mitigation: the configured wacli SQLite store is opened only for group-title fallback, with SQLite read-only flags; errors are non-fatal and do not expose database contents.Privacy and Data Hygiene (required)
pass|needs-follow-up): passCompatibility / Migration
Yes/No): YesYes/No): No; existing optionalstore_dirgains a read-only fallback use.Yes/No): NoHuman Verification (required)
What was personally validated beyond CI:
ChannelMessage.chat_title.ChatName, blank title, non-group messages, unavailable/invalid store, and webhook authentication behavior.Side Effects / Blast Radius (required)
spawn_blocking, opens read-only, fails open to no title, and logs failures at debug level.Agent Collaboration Notes (recommended)
AGENTS.md+CONTRIBUTING.md): ConfirmedRollback Plan (required)
channels_config.wacli.store_dirto disable the database fallback while retaining payload titles.untitled, or debug logs report a read-only title lookup failure.Risks and Mitigations
chats/groupslookup order, group-only execution, and non-fatal fallback behavior.