test: gate every deterministic example suite - #2
Merged
Conversation
josemontesdeoca
changed the title
The three email-oriented replay kits (feedback-pulse, press-desk, support-inbox-router) lived inside the vendored skill snapshot because that is where they sat upstream. They are this harness's tests, not skill content: the generators read nothing from the example directory, and upstream no longer ships them. Moving them under tests/open-prose/examples/ puts all sixteen suites behind the one include glob the root gate already had, and leaves skills/open-prose/ a pure snapshot that must never be edited in place. The regenerated replay fixtures are kept: a fresh generation is byte-identical to them and differs from the previously committed ones, which were produced by an earlier SDK build. These kits were never in CI, so the drift went unnoticed until now.
josemontesdeoca
changed the title
josemontesdeoca
marked this pull request as ready for review
August 26, 2026 01:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every deterministic example suite now runs through the root offline gate. Thirteen already did; the three email-oriented kits (
feedback-pulse,press-desk,support-inbox-router) only ran through their own local configs and were never in CI.What changes
tests/open-prose/examples/, beside the other thirteen. They are this harness's tests, not skill content: their generators read nothing from the example directory, and upstream no longer ships them. The rootincludestays the single glob it already had, andskills/open-prose/is once again a pure snapshot that is never edited in place (skills/README.mdsays so).two regenerations yield identical receipts.json) still holds, so this is deterministic drift that CI would have caught had the kits been gated. One stale world-model version is removed with it.Verification
pnpm test:examples— 16 Vitest files, 202 tests, plus the offline eval-harness suite;git diff --checkclean. The vendoredskills/open-prose/tree diffs againstopenprose/prose@779138a6only by the absence of the moved kit files.