Repository navigation
Conversation
tt-a1i
marked this pull request as ready for review
October 15, 2026 09:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native extension module graphs have different navigation wrapper constructors, so instanceof misses nested management strips.
Value
Repeated Down can move between workflow and subagent strips without losing ordinary editor input.
Approach
Integrate original #727 by @ooiuuii, preserving original commit
6de6763fa70879b5be4c9cdc51bda8af6583e847and contributor history through a normal merge with fixed mainf98d6a4737461ba8d8ee100f113b5a7c3a0001a0. The original PR remains open; this companion provides the tested integration because maintainer edits are disabled on its fork.Recognize precisely the existing three callable navigation methods on the base editor. Preserve method receivers and existing editor layer lifecycle; introduce no global focus manager or alternate loader. Keep the real production-entrypoint DefaultResourceLoader regression, add a fixture-wide network-request prohibition, and use current Pi 1.2 signatures/context.
Merge fixed main
f98d6a47normally while retaining original contributor history. Frozen local headbe7e05680817a6be6a043b5e3e23ad27435fd732, treee7609b9c696fa873328026a7176968fc0cf2fbbc.Validation
Frozen install, typecheck, repository format/lint and diff checks pass. 6 focused tests passed. The loader evaluates seven actual production extension entrypoints, proves different wrapper constructors, exercises repeated workflow/subagent cycling, newly available/single/hidden strips, text/Up/Left/Escape/shortcut delegation, auth-preflight settlement and shutdown. Zero fixture network requests and no parent model delivery. External #741 combined-tree suite: 18 passed, preserving its captured-UI lifecycle fix.
Isolated Pi 1.2.0 provenance/unique absolute package recorded. The real DefaultResourceLoader test is native module/component seam evidence; separate actual PTY startup capture is only startup evidence and does not establish interactive two-strip operator navigation.
Actual interactive two-strip operator acceptance and /new/reload witness remain unverified. Exact frozen-head
bun run checkandbun run testboth exit 0: Node 2,450 passed / 9 skipped / 0 failed; UI 88 files / 1,338 passed. Head/tree/clean guards remain identical before and after.Two independent final native/design and correctness reviews passed on the exact frozen head. Native PTY provenance retains its original HEAD and recorded working-tree identity; relevant production blobs match this final source, without claiming a fresh final-head manual run. Independent last-push approval remains a merge gate.
Exact-head GitHub CI passed on
be7e05680817a6be6a043b5e3e23ad27435fd732: all 18 critical checks are successful; the optional notification check is skipped. The frozen localbun run checkandbun run testboth exited 0 with unchanged head/tree and a clean worktree. Independent approval is still required.Impact
User: management-strip navigation composition changes. Model/schema/persistence/credentials: no change. Runtime: existing native editor/focus lifecycle remains the owner.