Skip to content

fix(tui): integrate #727 native navigation across module graphs - #845

Open
tt-a1i wants to merge 2 commits into
mainfrom
codex/pr727-ready
Open

tt-a1i wants to merge 2 commits into
mainfrom
codex/pr727-ready

Conversation

@tt-a1i

@tt-a1i tt-a1i commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Native extension module graphs have different navigation wrapper constructors, so instanceof misses nested management strips.

Value

Repeated Down can move between workflow and subagent strips without losing ordinary editor input.

Approach

Integrate original #727 by @ooiuuii, preserving original commit 6de6763fa70879b5be4c9cdc51bda8af6583e847 and contributor history through a normal merge with fixed main f98d6a4737461ba8d8ee100f113b5a7c3a0001a0. The original PR remains open; this companion provides the tested integration because maintainer edits are disabled on its fork.

Recognize precisely the existing three callable navigation methods on the base editor. Preserve method receivers and existing editor layer lifecycle; introduce no global focus manager or alternate loader. Keep the real production-entrypoint DefaultResourceLoader regression, add a fixture-wide network-request prohibition, and use current Pi 1.2 signatures/context.

Merge fixed main f98d6a47 normally while retaining original contributor history. Frozen local head be7e05680817a6be6a043b5e3e23ad27435fd732, tree e7609b9c696fa873328026a7176968fc0cf2fbbc.

Validation

Frozen install, typecheck, repository format/lint and diff checks pass. 6 focused tests passed. The loader evaluates seven actual production extension entrypoints, proves different wrapper constructors, exercises repeated workflow/subagent cycling, newly available/single/hidden strips, text/Up/Left/Escape/shortcut delegation, auth-preflight settlement and shutdown. Zero fixture network requests and no parent model delivery. External #741 combined-tree suite: 18 passed, preserving its captured-UI lifecycle fix.

Isolated Pi 1.2.0 provenance/unique absolute package recorded. The real DefaultResourceLoader test is native module/component seam evidence; separate actual PTY startup capture is only startup evidence and does not establish interactive two-strip operator navigation.

Actual interactive two-strip operator acceptance and /new/reload witness remain unverified. Exact frozen-head bun run check and bun run test both exit 0: Node 2,450 passed / 9 skipped / 0 failed; UI 88 files / 1,338 passed. Head/tree/clean guards remain identical before and after.

Two independent final native/design and correctness reviews passed on the exact frozen head. Native PTY provenance retains its original HEAD and recorded working-tree identity; relevant production blobs match this final source, without claiming a fresh final-head manual run. Independent last-push approval remains a merge gate.

Exact-head GitHub CI passed on be7e05680817a6be6a043b5e3e23ad27435fd732: all 18 critical checks are successful; the optional notification check is skipped. The frozen local bun run check and bun run test both exited 0 with unchanged head/tree and a clean worktree. Independent approval is still required.

Impact

User: management-strip navigation composition changes. Model/schema/persistence/credentials: no change. Runtime: existing native editor/focus lifecycle remains the owner.

@tt-a1i
tt-a1i marked this pull request as ready for review October 15, 2026 09:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants