Repository navigation
Conversation
627150795
force-pushed
the
codex/issue-829-setup-config-lock-timeout
branch
from
October 14, 2026 15:29
2513e65 to
415f35b
Compare
tt-a1i
previously approved these changes
Oct 15, 2026
tt-a1i
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed exact head 415f35bfe3653913f133194f48cc211f79e16438 against f98d6a4737461ba8d8ee100f113b5a7c3a0001a0. Independent design and correctness passes found no blocking findings. Focused setup-config tests (36/36), bun run check, and the full macOS Node 26 suite passed; current-head CI is green. The successful-current-process identity cache preserves unknown-owner fail-closed behavior, and the wait deadline uses monotonic time. Scope remains Issue #829 item 3; no broader closure or Windows manual-smoke claim.
This was referenced Oct 15, 2026
627150795
force-pushed
the
codex/issue-829-setup-config-lock-timeout
branch
from
October 17, 2026 08:32
415f35b to
598f429
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #863 replaced per-process start-time queries with heartbeat leases, setup-config lock acquisition still used wall-clock time for its elapsed patience and hard deadlines. A system clock adjustment can shorten or extend a wait on an untrusted lock.
Value
Elapsed lock-wait budgets now use a monotonic clock, while stale-lock checks continue to compare filesystem timestamps with wall-clock time. Uncertain lock ownership still fails closed without changing the configuration.
Approach
performance.now()for the patience deadline, hard deadline, and recheck timer.Validation
Base:
708a44b52cb260cb6c35c25c4f5bd63ebfec369cFinal HEAD:
598f429ae266f666a959e54150042ca6f335624anode --test --experimental-strip-types tests/extensions/shared/setup-config.test.ts— 47 passed, 0 failed.bun run check— passed.bun run test— 2,473 passed, 14 skipped, 35 failed. Thirty-four failures were WindowsEPERMwhile creating symlink fixtures; one dependent transcript-search assertion also failed after its symlink fixture could not be created.git diff --check origin/main...HEAD— passed.39017765773— 17/17 jobs succeeded; the PR reports 18/18 checks successful on this final HEAD.Impact
No persisted config or lock-file schema changes. Only elapsed wait timing changes; filesystem timestamp checks retain wall-clock semantics. No config mutation occurs while lock ownership is uncertain.