Back off Cloudability 429 rate limits during discovery#2336
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses OPS-4432 by improving how the engine backs off when Cloudability discovery hits HTTP 429 rate limits, using server-provided Retry-After when available and adding jitter to avoid synchronized retries.
Changes:
- Extend shared retry metadata to represent generic HTTP 429s and non-retryable HTTP client errors.
- Add Cloudability-specific retry classification in the engine (429 uses capped base+jitter delay; permanent 4xx are not retried).
- Implement RFC 7231
Retry-Afterparsing inblocks-commonand haveHttpErrorprefer it over Azure’s custom retry header.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/lib/flow-run/execution/step-output.ts | Expands retry metadata types to include HTTP 429 and permanent client error classifications. |
| packages/engine/src/lib/helper/error-handling.ts | Adds Cloudability 429 backoff with additive jitter and prevents retries for permanent 4xx client errors. |
| packages/engine/test/helper/error-handling.test.ts | Adds deterministic tests for Cloudability 429 delay/jitter behavior and permanent client error non-retry behavior. |
| packages/blocks/common/src/lib/http/index.ts | Re-exports the new standard Retry-After parser from the HTTP module barrel. |
| packages/blocks/common/src/lib/http/core/standard-retry-after.ts | Adds RFC 7231-compliant Retry-After parsing (delta-seconds and HTTP-date) with a 10-minute cap. |
| packages/blocks/common/src/lib/http/core/http-error.ts | Makes HttpError.retryAfterMs prefer standard Retry-After and fall back to Azure-specific header parsing. |
| packages/blocks/azure/test/standard-retry-after.test.ts | Adds unit coverage for Retry-After parsing behavior. |
| packages/blocks/azure/test/http-error-retry-after.test.ts | Adds unit coverage for HttpError.retryAfterMs precedence and 429-only behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ravikiranvm
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes OPS-4432