Skip to content

feat(custom-currencies): add custom currencies support to ledger#4549

Draft
mark-vass-konghq wants to merge 4 commits into
mainfrom
feat/add-custom-currencies-support-to-ledger
Draft

feat(custom-currencies): add custom currencies support to ledger#4549
mark-vass-konghq wants to merge 4 commits into
mainfrom
feat/add-custom-currencies-support-to-ledger

Conversation

@mark-vass-konghq

Copy link
Copy Markdown
Contributor

No description provided.

@mark-vass-konghq mark-vass-konghq self-assigned this Jun 22, 2026
@mark-vass-konghq mark-vass-konghq added release-note/feature Release note: Exciting New Features area/billing labels Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 611984c6-d77e-452f-bf3d-77e1e71ce8e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-custom-currencies-support-to-ledger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mark-vass-konghq mark-vass-konghq force-pushed the feat/add-custom-currencies-support-to-ledger branch from 4dbfd70 to e82d034 Compare June 22, 2026 11:38
Comment on lines +4 to +20
ALTER TABLE "billing_invoice_lines" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "billing_invoice_split_line_groups" table
ALTER TABLE "billing_invoice_split_line_groups" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "billing_invoices" table
ALTER TABLE "billing_invoices" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "billing_standard_invoice_detailed_lines" table
ALTER TABLE "billing_standard_invoice_detailed_lines" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "charge_credit_purchases" table
ALTER TABLE "charge_credit_purchases" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "charge_flat_fee_run_detailed_lines" table
ALTER TABLE "charge_flat_fee_run_detailed_lines" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "charge_flat_fees" table
ALTER TABLE "charge_flat_fees" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "charge_usage_based" table
ALTER TABLE "charge_usage_based" ALTER COLUMN "currency" TYPE character varying(24);
-- modify "charge_usage_based_run_detailed_line" table
ALTER TABLE "charge_usage_based_run_detailed_line" ALTER COLUMN "currency" TYPE character varying(24);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's only change those parts of the db where this makes sense for this change if possible.

e.g. billing will not use non-fiat currencies as currency.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that's my recommendation.

@mark-vass-konghq mark-vass-konghq requested a review from turip June 23, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/billing release-note/feature Release note: Exciting New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants