Skip to content

Implement jacobian calculation and energy and angle transformation#3935

Draft
GuySten wants to merge 1 commit intoopenmc-dev:developfrom
GuySten:lab-com-pdf-sample
Draft

Implement jacobian calculation and energy and angle transformation#3935
GuySten wants to merge 1 commit intoopenmc-dev:developfrom
GuySten:lab-com-pdf-sample

Conversation

@GuySten
Copy link
Copy Markdown
Contributor

@GuySten GuySten commented May 6, 2026

Description

This PR is a follow up to #3550.
In that PR angular pdf was calculated and outgoing energy was sampled for various kinematic probabilities.
The problem is that some angle energies are given in center of mass frame while we want the angular probabilities and energy in lab frame.

This PR fix that by implementing transformation between COM <->LAB and calculating the jacobian to convert angular probabilities between LAB <-> COM reference frames.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant