Allow Mesh.volumes property for 1D and 2D RegularMesh#3914
Merged
paulromano merged 1 commit intoopenmc-dev:developfrom May 6, 2026
Merged
Allow Mesh.volumes property for 1D and 2D RegularMesh#3914paulromano merged 1 commit intoopenmc-dev:developfrom
paulromano merged 1 commit intoopenmc-dev:developfrom
Conversation
5 tasks
Member
Author
|
@pshriwise is there any chance you can take a peak at this as I think it removes a defensive check you originally put in. |
paulromano
changed the title
paulromano
approved these changes
May 6, 2026
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
LGTM. Thanks @shimwell!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To help with PR #3877 it would be useful if we can get volumes for 1d and 2d meshes. @pshriwise is this ok to remove this defensive check so that meshes with dimensions not equal to 3 are allowed, I think this might come from a time when meshes were only 3d?
Fixes # (issue)
Checklist
~ - [ ] I have run clang-format (version 18) on any C++ source files (if applicable) ~
~ - [ ] I have added tests that prove my fix is effective or that my feature works (if applicable) ~