fix: pass commit message via env var in Actions template - #32
Open
jpignata wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Actions CI/CD template interpolated
${{ github.event.head_commit.message }}directly into arun:script:Commit messages can contain attacker-controlled text. Interpolating
github.event.*values into shell scripts is a known Actions pitfall that enables script injection, since expression substitution happens before the shell parses the script.This PR applies GitHub's recommended mitigation: pass the value through an intermediate environment variable so it's treated as shell data, never re-parsed as code. It also passes the API key via the
OPENLAYER_API_KEYenv var (which the CLI already reads) instead of the--api-keycommand-line flag, so the key no longer appears in the process list.Ref: GitHub Actions security hardening — Using an intermediate environment variable