Add US Live Flood Gauges (geolibre-flood-gauges) 0.4.1 - #49
Conversation
Live NOAA/NWPS river and coastal gauge layer by flood.live: flood-category symbology, H3 flood overview at low zoom, per-gauge hydrograph panel, and ?flood-gauge= deep links. Bundle committed as emitted then whitespace- minified with npm run minify (fork PRs run it themselves per README); validate_plugins.mjs passes locally; docs/plugins.md regenerated.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
📝 WalkthroughWalkthroughThe registry now lists four additional plugins. The US Live Flood Gauges plugin adds a manifest and stylesheet. The registry metadata includes the new plugin entry. ChangesPlugin registry expansion
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds the flood-gauge plugin and registry documentation with no actionable merge-blocking risk identified at the current head. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
@giswqs ready for review. Fully built by agents (ported some of flood.live functions, so pretty straightforward). |
|
/claude-review |
|
@chuofringer Amazing work! Thank you for your contribution.
|
Code reviewI reviewed the diff ( Bugs: None found. The plugin's Security: No injection or exfiltration issues found (medium confidence — logic review of a 322 KB single-line minified bundle is inherently limited to pattern-matching). No Performance: None found — nothing in the diff itself (registry JSON, docs, manifest, CSS) raises performance concerns; the plugin's internal refresh/change-detection logic described in the PR body isn't independently verifiable from a minified bundle. Quality:
CLAUDE.md: No |
- Scope the bundled uPlot vendor stylesheet under `.fg-hydrograph` so the plugin's globally-injected CSS no longer defines unprefixed generic class names (`.uplot`, `.u-legend`, `.u-select`, `.u-axis`, `.u-cursor-*`, ...) that could collide with the host app or another plugin bundling uPlot. All 26 vendor rules are prefixed; the plugin's own `.fg-` rules are unchanged. Safe because the uPlot instance is constructed with the `div.fg-hydrograph` container as its target, so every element uPlot creates lives inside that subtree.

Adds US Live Flood Gauges — a live layer of 10,000+ NOAA/NWPS river and coastal flood gauges, by the team behind flood.live. This is the plugin discussed with the maintainer in GeoLibre#2009.
What it does
?flood-gauge=<LID>deep links; project-state save/restore; full teardown on deactivate.Checklist against the contributing rules
pluginexport, id/name/version matchplugin.json; noactiveByDefault; CSS fully.fg--prefixed and theme-token based.plugins/geolibre-flood-gauges/committed as emitted, thennpm run minifyrun locally (fork PRs can't receive the workflow push);npm run minify:checkandnode scripts/validate_plugins.mjsboth pass locally.manifestUrl,minGeoLibreVersion: "2.0.0"— CI-tested in our repo with a Playwright suite against pinned v2.0.0 and v2.6.0 web builds, plus currentmain.docs/plugins.mdregenerated viagenerate_plugins_page.py.Source & QA: https://github.com/chuofringer/geolibre-flood-gauges — MIT, 137 unit/host-contract tests, e2e smoke (deep link, refresh-in-place, basemap-switch survival), weekly live-NOAA canary, tagged releases with the packaged zip.
Happy to adjust anything in review. First-time contributor here, so a maintainer
/claude-reviewis needed per the repo's setup.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation