-
-
Notifications
You must be signed in to change notification settings - Fork 670
feat: show basemap thumbnails in the Basemaps panel #2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
873bbd7
feat: show raster basemap thumbnails in the Basemaps panel
kongdd 51f7410
feat: preview style basemaps with a swatch then a map snapshot
kongdd 4e55251
style: auto-format (ruff + oxfmt) [pre-commit.ci]
pre-commit-ci[bot] a41c265
test: cover basemap preview URL substitution and key skipping
kongdd 2348dff
style: auto-format (ruff + oxfmt) [pre-commit.ci]
pre-commit-ci[bot] 6a4b0e4
Merge branch 'main' into feat/basemap-thumbnails
kongdd bd72818
Merge branch 'main' into feat/basemap-thumbnails
kongdd b103538
Address review feedback
giswqs fd39208
Address review feedback
giswqs 5fb7d7b
Address review feedback
giswqs 5debefa
Address review feedback
giswqs 3402f64
Address review feedback
giswqs 539f369
Address review feedback
giswqs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality (medium confidence): the real thumbnail (
.geolibre-basemap-thumbnail, below) pins itself togrid-row: 1 / span 3so it spans the row's full height regardless of how many text lines are next to it. This::before"pending" placeholder is the same size (56×42) but doesn't setgrid-row, so it will fall into the grid's default auto-placed cell instead of spanning all 3 rows like the thumbnail it's standing in for. If the row's other grid items span multiple rows too, the placeholder box and the eventual thumbnail likely won't occupy the same visual footprint, causing a layout shift when the pending placeholder is replaced by the real<img>.