feat(dotnet-sdk): configurable client credentials token url - #505
feat(dotnet-sdk): configurable client credentials token url#505alex-zyl wants to merge 1 commit into
Conversation
|
|
5231b3f to
a203e06
Compare
|
Thanks for the PR @alex-zyl - sorry it's taking a bit longer to review, we're clearing through a backlog of .NET related changes and PRs and hopefully this week or early next week we can get this reviewed and merged |
|
No worries, @rhamzeh Luckily the issue with hardcoded token endpoint subpath can be workedaround by providing own instance of http client where we can overwrite request url |
|
Hey @alex-zyl, just an opinion; but seems to me we're not addressing the root issue, a better solution should involve Discovery, it might require some work though. On the other hand, if a workaround is to be provided, I think the PR might introduce edge cases and breaking changes on clients relying already on that PathTemplate; just and idea but why just not adding a new variable to the ClientConfiguration.Credentials and use it for the PathTemplate if not null? |
|
This PR has had no human activity for 90 days, so it has been marked This is automated backlog grooming, not a judgment on the work. What happens next, unless there is activity:
To keep it open, push a commit or leave a comment, and the clock will reset. For work that should not auto-close, such as an RFC or long-running experiment, ask a maintainer to add |
|
This PR has had no human activity for 30 days since being marked It will be closed in 30 days unless there is new activity. If the work still matters, this is the moment to say so: leave a comment, push a commit, or ask a maintainer to add If this work is no longer being pursued, no action is needed. |
Description
Makes token endpoint configurable.
References
#238
Review Checklist
main