fix: render current config in studio template and prevent auto-save crash#137
fix: render current config in studio template and prevent auto-save crash#137navinkarkera wants to merge 1 commit into
Conversation
…rash Move self.seen = True from get_client_configuration to student_view so Studio auto-save (which calls studio_view -> get_client_configuration) does not write Scope.user_info and crash. Pass actual configuration values into the Django template context instead of relying on hardcoded defaults.
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Pass data from backend to studio editor instead of hardcoded field values. This allows authors to see current configuration values.
Also moves self.seen = True from get_client_configuration to student_view so Studio auto-save (which calls studio_view -> get_client_configuration) does not write Scope.user_info and crash. Pass actual configuration values into the Django template context instead of relying on hardcoded defaults.
Related
Private-ref: https://tasks.opencraft.com/browse/FAL-3835Test instructions
Follow steps given in #135 and verify that the bug is fixed.