bump odrcore to 5.0.4

[andiwand]

No description provided.

[claude]

Claude finished @andiwand's task —— View job

---

PR Review: Bump odrcore to 5.0.4

Summary

This PR updates the odrcore dependency from version 5.0.2 to 5.0.4 in the Conan configuration file. The change also modifies the shared option from True to False, switching from dynamic to static linking.

Changes Identified

In app/conanfile.txt:

• Version bump: odrcore/5.0.2 → odrcore/5.0.4
• Linking change: odrcore/*:shared=True → odrcore/*:shared=False

Code Quality and Best Practices ✅

• The version bump follows semantic versioning (patch release)
• Configuration file structure is maintained correctly
• No syntax errors or formatting issues

Potential Bugs or Issues ⚠️

1. Static vs Dynamic Linking Change: The switch from shared=True to shared=False is a significant change that wasn't mentioned in the PR description. This changes the library from dynamic (.so) to static (.a) linking, which could have implications:
   • APK Size: Static linking will increase the APK size as the library code is embedded directly
   • Memory Usage: Each process will have its own copy of the library code
   • Compatibility: Need to ensure all dependent native code is compatible with static linking

Performance Considerations 📊

• Static linking benefits: Slightly faster startup time, no runtime dynamic linking overhead
• Static linking drawbacks: Larger APK size, higher memory usage if multiple processes use the library
• For an Android app, the impact depends on how the native library is used

Security Concerns 🔒

• Updating from 5.0.2 to 5.0.4 (patch releases) typically includes bug fixes and security patches
• Recommendation: Check the odrcore release notes for any security fixes between 5.0.2 and 5.0.4
• Static linking means security updates require rebuilding and redistributing the entire app

Test Coverage 🧪

• No test changes included in this PR
• Recommendation:
  • Run the existing test suite: ./gradlew connectedAndroidTest
  • Verify the app builds correctly: ./gradlew assembleProDebug
  • Test document loading functionality to ensure the core library works as expected
  • Compare APK sizes before and after the change

Additional Recommendations

1. PR Description: Please add a description explaining:

   • Why the version is being bumped
   • Why the linking type was changed from shared to static
   • Any breaking changes or migration steps needed

2. Changelog Review: It would be helpful to review the odrcore changelog for versions 5.0.3 and 5.0.4 to understand what changes are included

3. Build Verification: Ensure the native library builds correctly with the new configuration across all supported architectures (armv8, armv7, x86, x86_64)

Verdict

The version bump itself appears straightforward, but the undocumented change from dynamic to static linking raises questions. This change should be intentional and well-understood before merging.