Skip to content

chore: move to dev-kit v3.0.3 - #867

Closed
cbrgm wants to merge 1 commit into
mainfrom
chore/dev-kit-v3.0.3
Closed

cbrgm wants to merge 1 commit into
mainfrom
chore/dev-kit-v3.0.3

Conversation

@cbrgm

@cbrgm cbrgm commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

What

Moves every dev-kit pin from v3.0.2 to v3.0.3: workflow stubs, Makefile, flake.nix, flake.lock. Same shape as 5c18d20.

Why

Picks up opendefensecloud/dev-kit#53. Since the move to v3, Add issues to project fails at startup on every opened PR -> https://github.com/opendefensecloud/solution-arsenal/actions/runs/38392325299

The workflow is requesting 'contents: read', but is only allowed 'contents: none'.

The reusable workflow asked for more than our stub (permissions: {}) hands down. v3.0.3 drops the request, the stub stays as it is.

v3.0.2...v3.0.3 contains only that one fix.

Testing

$ make check-dev-kit-pins
dev-kit pins agree: workflows=v3.0.3 Makefile=v3.0.3 flake.nix=v3.0.3 flake.lock=e6fa735852126c9f6b6d4eb4c97c4ba48587b4a5

flake.lock relocked with nix flake update dev-kit (nix in a container, no local install).

The real test is this PR itself: opening it triggers Add issues to project with the new pin.

Checklist

  • Tests added/updated, or confirmed that no tests are required (pin bump only)
  • No breaking changes, or upgrade path documented above
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Picks up the issues-add-to-project fix (dev-kit#53). The reusable
workflow asked for `contents: read` while our stub calls it with
`permissions: {}`, so the run failed at startup on every opened PR
since the move to v3 and nothing landed on the project board.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a524e46-329c-4cc4-b455-88ad566ff836
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cbrgm
cbrgm marked this pull request as ready for review October 13, 2026 13:27
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38402349487

Coverage increased (+0.03%) to 78.83%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 4 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

4 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
pkg/controller/rendertask_controller.go 2 86.21%
pkg/controller/target_controller.go 2 78.21%

Coverage Stats

Coverage Status
Relevant Lines: 6514
Covered Lines: 5135
Line Coverage: 78.83%
Coverage Strength: 31.8 hits per line

💛 - Coveralls

@cbrgm

cbrgm commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

@AlexHardAtWork is working on some other fixes here, so maybe its worth waiting until his changes are done and bump straight to v3.0.4 if needed.

@cbrgm cbrgm closed this Oct 15, 2026
@cbrgm

cbrgm commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Closing this one since we were straight away update to 3.0.4

@AlexHardAtWork AlexHardAtWork mentioned this pull request Oct 15, 2026
4 tasks done
AlexHardAtWork added a commit that referenced this pull request Oct 15, 2026
## What

Moves every dev-kit pin from v3.0.2 to v3.1.0: workflow stubs,
`Makefile`, `flake.nix`, `flake.lock`. Supersedes #867 (v3.0.3).

## Why

v3.1.0's `renovate-dev-kit-lock` also relocks `go-overlay` on
`renovate/go-version` (dev-kit#56). That is what #862 lacks: Go 1.27.2
isn't in the locked overlay, so every nix job fails evaluating the
shell. Picks up v3.0.3/v3.0.4 on the way: the `issues-*` reusable
workflows no longer ask for permissions the stubs don't grant
(dev-kit#53, #54).

## Testing

`make check-dev-kit-pins` agrees on v3.1.0; the `flake.lock` diff is the
dev-kit node only. Commit hooks (`fmt`, `lint`) pass.

## Notes for reviewers

- After merge, the plan is to rebase #862 (remove its `automerge` label
first). Expect a `dev-kit-bot` commit relocking `go-overlay`, then green
CI. Auto-approve will reject that PR because it now has two commits;
merge it by hand.
- No stub changes needed: v3.0.4 and v3.1.0 add no inputs or permissions
that the stubs have to pass.

## Checklist
- [x] Tests added/updated, or confirmed that no tests are required
- [x] No breaking changes, or upgrade path documented above
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated the project’s development and automation tooling to newer
shared versions.
  * No changes to user-facing features or application behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants