Repository navigation
ci: use dev-kit setup-nix composite action - #792
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe workflows now use the shared dev-kit ChangesShared Nix workflow setup
Renovate workflow update
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change centralizes existing Nix and Cachix setup across six workflows and refreshes related action pins without an intended behavior change; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 33647610448Coverage increased (+0.09%) to 80.264%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
What
Replace the inline nix + Cachix preamble in six workflows with dev-kit's
setup-nixcomposite action, and put all dev-kit references on v2.2.0.
Why
The installer + Cachix pair was copy-pasted at 8 call sites. Extracting it to dev-kit
(#30, released in v2.2.0) means the installer
choice is changed in one place instead of fourteen once artifact-conduit adopts the same action.
Solar also carried three dev-kit pins at two different versions. Now one.
Testing
update-action-pinscheck passes — everyuses:is SHA-pinned.actionlintclean before the pin swap; the only findings are two pre-existing SC2086infos in
docker.yaml/release-please.yaml, both untouched here.golang,codegen,helm-lint,helm-publish,test-e2eandtest-demoall go through the new action.Notes for reviewers
No behaviour change intended — same installer, same pins, same Cachix cache.
determinate: falseand the emptydiagnostic-endpointmoved into the action, alongwith the comments explaining them. Same values as before.
secretscontext,so
cachix-auth-token/cachix-signing-keyare inputs. Both default to'', which isthe existing fork-PR read-only fallback.
diff-checkandrenovate-auto-approvemoved v1.0.15 → v2.2.0. Both files arebyte-identical between those tags — a pin refresh, not an upgrade.
release-please.yamlanddocker.yamlkeep their own setup; out of scope.Prepares artifact-conduit#441, which will use the same action.
Checklist
Summary by CodeRabbit
Chores
Tests