Skip to content

chore(dev): drop the unused OCM vars from dev-cluster.sh - #737

Merged
cbrgm merged 1 commit into
mainfrom
chore/drop-unused-dev-cluster-ocm-vars
Aug 6, 2026
Merged

chore(dev): drop the unused OCM vars from dev-cluster.sh#737
cbrgm merged 1 commit into
mainfrom
chore/drop-unused-dev-cluster-ocm-vars

Conversation

@cbrgm

@cbrgm cbrgm commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

Remove the now-unused OCM_DEMO_DIR and OCM variables from hack/dev-cluster.sh.

Why

#733 moved the OCM transfer into hack/demo/transfer-discovery.sh, so dev-cluster.sh doesnt run ocm anymore. Both variables were left behind as dead declarations.@olzemal spotted OCM_DEMO_DIR in a review on #733 -> OCM is dead for the same reason, so go away :)

Testing

$ grep -nE '\bOCM\b|OCM_DEMO_DIR' hack/dev-cluster.sh   # nothing left
$ make shellcheck                                        # clean

No behavior change, the Makefile never passed these to the script (the ocm-transfer-demo target owns OCM separately).

Checklist

  • Tests added/updated (n/a, dead-code removal)
  • No breaking changes
  • Readable commit history (one commit)
  • AI code review considered and comments resolved

@cbrgm
chore(dev): drop the unused OCM vars from dev-cluster.sh
c44d9dd 
Since #733 moved the OCM transfer into transfer-discovery.sh, dev-cluster.sh no
longer runs ocm, so OCM_DEMO_DIR and OCM were left as dead declarations. Spotted
by olzemal on #733.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cbrgm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 50b4fbc5-98b9-486c-b8b8-a3ceb6f50612

📥 Commits

Reviewing files that changed from the base of the PR and between 386ae19 and c44d9dd.

📒 Files selected for processing (1)
  • hack/dev-cluster.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cbrgm
cbrgm merged commit 875449e into main Aug 6, 2026
22 checks passed
@cbrgm
cbrgm deleted the chore/drop-unused-dev-cluster-ocm-vars branch August 6, 2026 12:17
@ghost ghost mentioned this pull request Aug 6, 2026
Merged
rebEllieous added a commit that referenced this pull request Aug 24, 2026
@rebEllieous
chore(main): release 0.3.0 (#722)
41a7c38 
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.3.0-rc2...v0.3.0)
(2026-08-24)


* gate release-please app token on both app id and private key
([2c5d19e](2c5d19e))


### Features

- add cron workflow for solar catalog chaining
([6c61cff](6c61cff))
- add solar catalog chaining
([#744](#744))
([7001a5e](7001a5e))
- added status visualisation for the deployment workflow in the FE
([#664](#664))
([88dc1ee](88dc1ee))
- **api:** add ObjectReference type for cross-namespace resource
references
([30cecba](30cecba))
- **ci:** replace release-drafter with release-please
([#632](#632))
([#676](#676))
([64a05d9](64a05d9))
- **controller:** own Component lifecycle in a per-Component reconciler
([#745](#745))
([9ac867e](9ac867e))
- crud for k8s ressources in web ui
([#708](#708))
([83ba01b](83ba01b))
- deploy solar-ui as part of the solar chart
([#743](#743))
([3d1ac1e](3d1ac1e))
- **dev:** add make demo / demo-app / demo-clean for a one-command demo
([1524092](1524092))
- **dev:** make demo / demo-app / demo-clean for a one-command demo
([#734](#734))
([386ae19](386ae19))
- **discovery:** added resource watcher
([6d588b2](6d588b2))
- impl fe list views
([#645](#645))
([78c7fd7](78c7fd7))
- production-ready catalog transfer workflow, e2e tests
([#762](#762))
([4454e47](4454e47))
- pull secrets provision added for deployments to solar via ocm-kit
([#739](#739))
([8e3f8cb](8e3f8cb))
- **ui:** add resource detail pages with shared primitives
([#718](#718))
([e53d22a](e53d22a))
- **ui:** pkce implemented, local setup for remote zitadel in both auth
modes
([#764](#764))
([b531958](b531958))

### Bug Fixes

- apply suggestions from code review
([38d109b](38d109b))
- **ci:** address review findings on release-please migration
([a6dec29](a6dec29))
- **controller:** drop post-delete re-check that could strand a
terminating Component
([0366a34](0366a34))
- **controller:** guard the finalizer add with an optimistic lock
([4dbf867](4dbf867))
- **controller:** read the Component uncached before stripping the
finalizer
([f56ccc9](f56ccc9))
- **deps:** bump go-git to v5.19.2, fix OSV-Scanner findings
([7482013](7482013))
- **deps:** bump go-git to v5.19.2, fix OSV-Scanner on main
([#760](#760))
([b2783df](b2783df))
- **deps:** correct the openpgp importer list in the OSV ignore
([0759c3b](0759c3b))
- **deps:** keep crypto11 replace at v1.6.2 and tidy go.sum
([786d860](786d860))
- **deps:** migrate cenkalti/backoff imports from v5 to v7
([7b9ecdc](7b9ecdc))
- **deps:** point crypto11 replace at renamed eclipse-keypont module
([149f778](149f778))
- **deps:** resolve new CVEs flagged by osv-scanner
([#675](#675))
([c7334a5](c7334a5))
- **deps:** update dependencies (minor)
([26698c0](26698c0))
- **deps:** update dependencies (patch & digest)
([#663](#663))
([f4339d7](f4339d7))
- **deps:** update dependencies (patch & digest)
([#698](#698))
([29fc135](29fc135))
- **deps:** update go version in remaining places
([748b48f](748b48f))
- **deps:** update go-overlay to provide go 1.26.5
([e10b8af](e10b8af))
- **deps:** update go-overlay to provide go 1.26.6
([2c33ecc](2c33ecc))
- **deps:** update golang builder image to 1.26.6
([66a0e2a](66a0e2a))
- **deps:** update kubernetes dependencies
([#682](#682))
([aefbd19](aefbd19))
- **deps:** update kubernetes dependencies
([#728](#728))
([c16821b](c16821b))
- **deps:** update kubernetes dependencies to v0.36.4
([#772](#772))
([19448a6](19448a6))
- **deps:** update module github.com/cenkalti/backoff/v5 to v7
([#671](#671))
([6518ca3](6518ca3))
- **deps:** update module github.com/cenkalti/backoff/v5 to v7
([#674](#674))
([09777c6](09777c6))
- **deps:** update module github.com/cenkalti/backoff/v5 to v7
([#716](#716))
([6d464e2](6d464e2))
- **deps:** update module helm.sh/helm/v4 to v4.2.4
([#750](#750))
([2f5476a](2f5476a))
- **deps:** update module oras.land/oras-go/v2 to v2.6.2 [security]
([#696](#696))
([6b52133](6b52133))
- **dev:** deploy solar-discovery in scan mode so dev-cluster populates
the catalog
([eae09f2](eae09f2))
- **dev:** fail setup-discovery when the port-forward never becomes
ready
([626e436](626e436))
- **dev:** make dev-cluster reliably populate the catalog
([#731](#731))
([0af9386](0af9386))
- **dev:** use the ca-trusting ocmconfig and trap-clean the port-forward
in setup-discovery
([9ff18b6](9ff18b6))
- **discovery:** use errors.Is for http.ErrServerClosed check
([#693](#693))
([be17b8f](be17b8f))
- **discovery:** use strings.Cut to strip digest algorithm prefix
([#694](#694))
([1bf1856](1bf1856))
- document reference
([629555a](629555a))
- dont create renderbinding if renderartifact is terminating
([7168331](7168331))
- e2e test regression introduced with discovery api watch
([#727](#727))
([fa95810](fa95810))
- handle insecure deploy registry for bootstrap chart
([#660](#660))
([fb8de30](fb8de30))
- ignore terminating renderartifacts
([0cfc2fe](0cfc2fe)),
closes
[#619](#619)
- improve handling of terminating renderartifacts
([#730](#730))
([0570216](0570216))
- only run e2e test with the ok-to-e2e label
([391a2c2](391a2c2))
- registry resources
([#700](#700))
([756528e](756528e))
- remove orphaned devenv.nix file
([#705](#705))
([7dc25ca](7dc25ca))
- restructured renderartifact and -binding to solve a known problem
([#724](#724))
([c68104f](c68104f))
- retain deleting renderartifacts when they are still referenced by a
binding
([3603545](3603545))
- rstructured renderartifact and -binding to solve the bug
([c41158a](c41158a))
- tightened security around reference grants for RenderArtifacts, minor
fixes
([bc8c5d7](bc8c5d7))
- **ui:** derive ui-e2e backend URLs from UI_DEV_PORT and tighten auth
tests
([0982234](0982234))
- use local dir for dex certs
([#638](#638))
([8f875c8](8f875c8))

### Miscellaneous Chores

- add missing entries to the path filter of GitHub actions
([#670](#670))
([101e4c0](101e4c0))
- **deps:** update actions/cache action to v6
([#692](#692))
([23dd707](23dd707))
- **deps:** update actions/setup-go action to v7
([#721](#721))
([51c1fd5](51c1fd5))
- **deps:** update actions/setup-python action to v7
([#719](#719))
([76bc61e](76bc61e))
- **deps:** update dependencies (patch & digest)
([#683](#683))
([17728f1](17728f1))
- **deps:** update dependencies (patch & digest)
([#749](#749))
([62e20bf](62e20bf))
- **deps:** update dependencies (patch & digest)
([#771](#771))
([9afef5e](9afef5e))
- **deps:** update dependency @testing-library/jest-dom to v7
([#725](#725))
([b411a26](b411a26))
- **deps:** update dependency go to v1.26.5
([2bf738b](2bf738b))
- **deps:** update dependency go to v1.26.6
([63397b8](63397b8))
- **deps:** update dependency jsdom to v30
([#735](#735))
([2be1ea1](2be1ea1))
- **deps:** update dependency pillow to v12.3.0 [security]
([#699](#699))
([d658e68](d658e68))
- **deps:** update dependency typescript to v7
([#691](#691))
([349cd5f](349cd5f))
- **deps:** update golang version sync to v1.26.5
([#697](#697))
([422b1d4](422b1d4))
- **deps:** update golang:1.26.4 docker digest to 32c0e6e
([#662](#662))
([2833f64](2833f64))
- **deps:** update golang:1.26.4 docker digest to f96cc55
([e1ced04](e1ced04))
- **deps:** update golang:1.26.5 docker digest to 2005724
([#740](#740))
([a087073](a087073))
- **deps:** update golang:1.26.5 docker digest to 3aff665
([#712](#712))
([afe9193](afe9193))
- **dev:** drop the unused OCM vars from dev-cluster.sh
([#737](#737))
([875449e](875449e))
- fix issues surfaced by PR review
([4120973](4120973))
- fix target release view
([e347937](e347937))
- fixes and improvements after pr review
([43e0f6a](43e0f6a))
- improve CI docker caching
([#633](#633))
([213f23c](213f23c))
- improved accessability
([2dacb25](2dacb25))
- make codegen
([355611d](355611d))
- minor updates after PR review
([f2c8463](f2c8463))
- renamed make targets
([a6a901d](a6a901d))
- split up unit and integration tests, added tests
([#684](#684))
([1aca0e4](1aca0e4))
- trust-scope docker layer cache, tidy Dockerfile mounts
([17dac28](17dac28))
- **ui:** tidy up after the Zitadel integration
([2ac8011](2ac8011))
- update dev-kit and configure improved branch-protection
([#738](#738))
([132ab55](132ab55))
- update flake and remove kind version workaround
([#732](#732))
([ec91fc2](ec91fc2))


---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olzemal olzemal olzemal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbrgm @olzemal @trevex