Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yocaba
force-pushed
the
chore/full-version-pin-comments
branch
from
October 20, 2026 09:57
dfd7274 to
a670b4d
Compare
yocaba
force-pushed
the
chore/full-version-pin-comments
branch
from
October 20, 2026 11:57
2430919 to
459a9a8
Compare
3 of 4 tasks
yocaba
force-pushed
the
chore/full-version-pin-comments
branch
from
October 20, 2026 12:08
459a9a8 to
2c25cc9
Compare
yocaba
added this pull request to stack #69
October 20, 2026 13:52
yocaba
force-pushed
the
chore/full-version-pin-comments
branch
from
October 20, 2026 20:24
2c25cc9 to
56c5f68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
update-action-pins.ymlfails a PR when a pin's SHA changes but its version comment doesn't, or when a pin's comment is anything but# <version>, and dev-kit's pin comments now name full release tags.Part of #47
Why
A pin whose SHA changes under the same version comment means upstream moved the tag, or the PR swapped the SHA. That is how a compromised tag reaches a digest update, and zizmor's audits don't catch it, since the moved tag still matches the comment. Full release tags (
# v7.0.1) keep the check quiet on legitimate updates; a major tag (# v7) moves with every release.zizmor's ref-version-mismatch audit only checks a pin whose comment is exactly
# <version>. Without a comment, or with any text after the version (a# zizmor: ignore[...]included), it skips the pin without a finding.Testing
scripts/test-update-action-pins.shruns the new steps from the workflow filerelease-drafter # v7andcachix-action # v17Notes for reviewers
# vNcomments see their next digest update fail until the comments name the full tag pointing at the same SHA (git ls-remote --tagslists them).# zizmor: ignore[...]can sit on a pin line anymore; the zizmor workflow for Check GitHub Action pins for impostor and mismatched commits in CI #47 won't honor ignores either.cachix/cachix-actionpublishes only major tags and movesv17, so each of its digest updates needs a human review and an admin merge.Checklist