Repository navigation
fix(flake-closure-diff): pass the head profile as an absolute path - #51
Merged
Merged
Conversation
nix reads a relative path argument as a flake reference: it resolved the .profile symlink and then rejected the store path with "is not a flake (because it's not a directory)", so every run failed at the report step. An absolute path under the store is recognised as a store path, which is what diff-closures wants. The base side was already absolute, from mktemp -d. Found on the first real run — solution-arsenal#858, the first consumer to call this — and reproduced locally: the relative form gives exactly the CI error, the absolute form prints the diff and exits 0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The workflow passes the intended absolute head-profile path to the closure-diff command. No merge-blocking issue is supported by the review. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title clearly and concisely describes the main change: passing the head profile as an absolute path. |
| Description check | |
The description explains the change, failure cause, reproduction, testing performed, impact, and checklist status. It does not use the template's exact Testing and Notes for reviewers headings, and it… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
flake-closure-difffailed on its first real run. One-line fix: pass the head profile as anabsolute path.
Why it failed
nix reads a relative path argument as a flake reference. It resolved the
.profilesymlink,found a store path that is a file, and rejected it. The base side was already absolute, from
mktemp -d; only the head side was relative, so every run failed at the report step.Reproduced locally against Solar's flake — the relative form gives exactly the CI error, the
absolute form prints the diff and exits 0:
Notes
opendefensecloud/solution-arsenal#858, the first consumer to call this workflow.feat: add check-dev-kit-pins and a flake.lock closure diff #44 said it had not run end to end; this is what that was worth.
differences, but a failure to compute the diff means the tool is broken — and that is the
only reason this bug was noticed rather than shipped quietly to every consumer.
be dropped from
#858— nothing depends on it.Checklist
Summary by CodeRabbit