Repository navigation
Split Go-specific targets out of common.mk into go.mk (non-breaking, after v3.0.0) #39
Description
Context
common.mk is meant to be language-agnostic, but three targets are Go-specific: mod, golangci-lint and envtest-binaries-sideload, plus the tools.lock pattern rule. A non-Go repo (e.g. a Rust one) gets them anyway.
Part of centralizing shared CI/build config in dev-kit: common.mk works for any repo, language modules are opt-in.
What needs to be solved
- Move the Go targets and the
tools.lockrule intogo.mk. go.mkis fetched and pinned the same way ascommon.mk(byDEV_KIT_VERSION), andupdate-common-mk-bootstrapwrites the bootstrap for both.- Document the migration: Go repos add the
go.mkinclude.
Acceptance criteria
-
common.mkcontains no Go-specific target or variable. - A Go consumer (Solar) runs
make mod golangci-lintwithgo.mkincluded, and gets a clear error without it. - A repo including only
common.mkrunsmake helpandmake scanwithout Go installed. - Release notes flag this as breaking.
Activity
dermorz commentedon Oct 5, 2026
Postponed past v3.0.0 — dev-kit 3.0 doesn't need the split, including for repos without Go code:
common.mkalready adapts to repos without ago.mod:lintonly addsgolangci-lintwhen there is one,.golangci.ymlis only fetched then, andTREEFMT_ARGSis derived.OS/ARCHfall back tounamewhengois missing. ocm-components runs oncommon.mktoday.tools.lockrule doesn't belong ingo.mk: it's a tool installer, not Go support. ocm-components has no Go code but installs theocmCLI through it (ocm ocm.software/ocm@v0.49.0), so moving it would forcego.mkon exactly the repos the split is meant for.When this is picked up (e.g. for the first repo with no Go at all, like knot), it can be non-breaking:
mod,golangci-lintandenvtest-binaries-sideloadtogo.mk; keeptools.lockand its pattern rule incommon.mk.common.mkfetches and includesgo.mkitself when ago.modexists, pinned byDEV_KIT_VERSIONlike the shared configs. Consumers change nothing, so no major release and no migration round.[-]Split Go-specific targets out of common.mk into go.mk[/-][+]Split Go-specific targets out of common.mk into go.mk (non-breaking, after v3.0.0)[/+]feat!: make governance workflows reusable (#41)