refactor: contract CANFAR interfaces while preserving behavior - #276
Open
shinybrar wants to merge 142 commits into
Open
refactor: contract CANFAR interfaces while preserving behavior#276shinybrar wants to merge 142 commits into
shinybrar wants to merge 142 commits into
Conversation
ci: gate full tests on merged code changes
fix(ci): address Wave 0 review findings
feat(config): establish bound Configuration editor
refactor(auth): modernize X.509 validation APIs
refactor(sessions): share native transport policy
refactor(ci): consolidate reusable workflows
docs(alma): replace screenshot guides with text workflow
Integrate the final platform and site documentation lane for #261 into feat/interfaces.
Integrate the Wave 7 ps status-filter help correction into feat/interfaces.
Integrate the Wave 7 client documentation lifecycle correction into feat/interfaces.
Integrate the resolved Wave 7 Standards and Simplify findings into feat/interfaces.
Merge the final review corrections for shared OIDC coordinator policy and domain terminology. Native synchronous and asynchronous transports remain separate.
Merge the final review corrections for atomic Configuration transitions and an internal server discovery implementation. Public ConfigurationEditor and canfar.server interfaces remain unchanged.
Merge the final architecture correction. HTTPClient behavior is now exercised through native sync and async clients with MockTransport and lifecycle contexts instead of private helper assertions.
shinybrar
marked this pull request as ready for review
August 18, 2026 10:09
Merge the focused corrections for every current github-code-quality thread on PR #276 while preserving the public server compatibility surface.
Merge the final test-only cleanup for the last github-code-quality thread on PR #276.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Contracts CANFAR internal interfaces and removes redundant machinery while preserving the shipped Python API, CLI, Configuration data, authentication, HTTP, Session, storage, logging, packaging, and documentation behavior.
Net epic change: 320 files, 9,069 insertions, 16,706 deletions across 142 commits; net reduction of 7,637 lines.
Highlights
Compatibility guarantees
Review
Validation
The credential-dependent full integration suite was not run because no live CANFAR Authentication Record and certificate were available, per repository policy.
Closes #244.