Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/lib/server/validation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,17 @@ describe('validatePackages', () => {
expect(result.valid).toBe(true);
});

it('should accept package names with plus character (e.g. logi-options+)', () => {
const packages = [
{ name: 'logi-options+', type: 'cask' },
{ name: 'gtk+', type: 'formula' }
];
const result = validatePackages(packages);

expect(result.valid).toBe(true);
expect(result.error).toBeUndefined();
});

it('should reject non-array input', () => {
const result = validatePackages('not an array' as any);

Expand Down
7 changes: 4 additions & 3 deletions src/lib/server/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ interface Package {
}

/** Validates packages array: prevents shell injection in package names.
* Package names must match standard package manager formats (alphanumeric, hyphens, underscores, dots, slashes for scoped packages).
* Package names must match standard package manager formats (alphanumeric, hyphens, underscores, dots, pluses, slashes for scoped packages).
* `+` is allowed because real Homebrew casks contain it (e.g. `logi-options+`, `gnupg@2.1+`).
* Types must be: formula, cask, tap, npm.
* Maximum 500 packages per config. */
export function validatePackages(packages: unknown): ValidationResult {
Expand Down Expand Up @@ -174,10 +175,10 @@ export function validatePackages(packages: unknown): ValidationResult {
return { valid: false, error: `Package name too long at index ${i}` };
}

if (!/^[@a-zA-Z0-9._\/-]+$/.test(name)) {
if (!/^[@a-zA-Z0-9._+\/-]+$/.test(name)) {
return {
valid: false,
error: `Invalid package name at index ${i}: "${name}". Only alphanumeric, hyphens, underscores, dots, @ and / allowed.`
error: `Invalid package name at index ${i}: "${name}". Only alphanumeric, hyphens, underscores, dots, plus, @ and / allowed.`
};
}

Expand Down
Loading