Repository navigation
Conversation
…-team#701) With the number row enabled, the first letter key of row 1 (q on QWERTY/QWERTZ, b on BÉPO) offered '%' on long-press although '%' is already permanently available on the corresponding row-2 key (f) - so '%' existed twice while '_' was not reachable from the base layout at all. Put '_' on the row-1 key instead. Configurations without the number row are unchanged (those keys show digit hints there), so '%' remains available on the f key in every configuration. Fixes openboard-team#701 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MiMoHo
force-pushed
the
fix/underscore-morekey
branch
from
September 9, 2026 15:22
2a72ba0 to
8aac677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the number row enabled, the long-press symbol hints contain
%twice — on the first key of row 1 (q on QWERTY/QWERTZ, b on BÉPO) and on the f key in row 2 — while_(underscore) is not reachable from the base layout at all (#701).Fix
Replace the duplicate
%on the row-1 key with_in thenumberRowEnabledcases ofrowkeys_qwerty1_left5.xml,rowkeys_qwertz1_left5.xmlandrowkeys_bepo1.xml.Why the row-1 key and not f (as originally suggested in the issue): the f key's
%is always present (also without the number row), whereas the row-1 hint only exists with the number row enabled. Changing f would remove%from the base layout entirely for users without the number row; changing the row-1 key keeps%available in every configuration and adds_where the duplicate used to be.Testing
Verified on an Android 15 emulator with the number row enabled: long-pressing q now inserts
_;%remains available on f. Configurations without the number row are untouched (those keys show digit hints there).Fixes #701
🤖 Generated with Claude Code