Repository navigation
Conversation
…#726) performAdditionToUserHistoryDictionary() returned early whenever auto-correction was turned off, so users who type with suggestions but without auto-correction never got their words learned - typed words were never offered as suggestions later (issues openboard-team#726, openboard-team#452). Gate learning on 'auto-correction OR suggestions enabled' instead. Sensitive fields keep their protection: password fields force isSuggestionsEnabledPerUserSettings() to false, and incognito mode still disables learning entirely. Fixes openboard-team#726 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MiMoHo
force-pushed
the
fix/learn-words-without-autocorrect
branch
from
September 9, 2026 15:22
b338ea3 to
13d1560
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typed words are never learned when auto-correction is disabled (#726, #452):
InputLogic.performAdditionToUserHistoryDictionary()returns early whenevermAutoCorrectionEnabledPerUserSettingsis false. Users who type with suggestions but without auto-correction never see their own words offered as suggestions.Fix
Gate learning on "auto-correction or suggestions enabled" instead of auto-correction alone:
isSuggestionsEnabledPerUserSettings()to false and incognito mode still disables learning entirely, so the original intent of the check — no unintended additions from sensitive fields — is preserved.Testing
Builds with the stock toolchain; keyboard smoke-tested on an Android 15 emulator (typing, suggestions). The condition change is deliberately minimal — a strict widening from
autoCorrecttoautoCorrect || suggestions, so no existing learning path is removed.Fixes #726
🤖 Generated with Claude Code