Skip to content

Added Centers Create fix - #138

Merged
staru09 merged 1 commit into
openMF:devfrom
Craig-Rosario:centers-fix
Aug 4, 2026
Merged

Added Centers Create fix#138
staru09 merged 1 commit into
openMF:devfrom
Craig-Rosario:centers-fix

Conversation

@Craig-Rosario

@Craig-Rosario Craig-Rosario commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

JIRA TICKET: MXWAR-109

Description

Added Centers Create fix and document OpenAPI errors for Edit Centers

Related issues and discussion

#{Issue Number}

Screenshots, if any

image

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at CONTRIBUTING.md.

Summary by CodeRabbit

  • New Features

    • Improved center form date handling with consistent formatting and localization.
    • Center forms now default to the dd MMMM yyyy date format and English locale.
  • Documentation

    • Documented missing fields in center and group API request models.

@Craig-Rosario
Craig-Rosario requested a review from a team August 4, 2026 05:32
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The center form now handles localized activation and submitted-on dates for browser date inputs. The form initializes date format and locale values. ISSUES.md documents missing fields in center-related update request models.

Changes

Center form date handling

Layer / File(s) Summary
Localized center date fields
src/pages/centers/CreateCenters.tsx
The form initializes dateFormat and locale. Activation and submitted-on dates convert between stored localized strings and browser date-input values. Empty values remain supported.

Center API gap documentation

Layer / File(s) Summary
Document center API gaps
ISSUES.md
The report documents missing staffId and externalId fields in PutCentersCenterIdRequest and PutGroupsGroupIdRequest.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: iohacker

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change as a fix to center creation, which matches the primary UI changes in the pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ISSUES.md`:
- Around line 227-229: Update the ISSUES.md entries for
PutCentersCenterIdRequest and PutGroupsGroupIdRequest so each model separately
lists its missing staffId and externalId fields; retain the existing endpoint
context for PutGroupsGroupIdRequest.

In `@src/pages/centers/CreateCenters.tsx`:
- Around line 166-185: Update the activationDate handler in CreateCenters.tsx
and the corresponding submittedOnDate handler at the sibling site to store the
input’s raw YYYY-MM-DD value directly, without parsing through Date or
local-time formatting. Keep any date formatting limited to UI display while
ensuring create7 receives the unchanged date-only values in both fields.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0467ecbc-9cab-47bc-9203-98905e2d0dd2

📥 Commits

Reviewing files that changed from the base of the PR and between 0085a1d and 93f8807.

📒 Files selected for processing (2)
  • ISSUES.md
  • src/pages/centers/CreateCenters.tsx

Comment thread ISSUES.md
Comment thread src/pages/centers/CreateCenters.tsx

@staru09 staru09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat

@staru09
staru09 merged commit 9bb286b into openMF:dev Aug 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants