Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-04 17:31 UTC Investigate required status check failures. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cleanup matches the dependency invariant and is covered for development and release bumps.
Review effort: Balanced
Findings: None
What changed in this PR
Automates cleanup of stale local workspace installs during version bumps, preventing post-release dependency-check failures.
Changes:
- Extracts local-package matching and adds released-install cleanup.
- Runs cleanup after version bumps with release/dev coverage.
- Makes
packagingavailable in release workflows.
| File | Description |
|---|---|
scripts/check_deps.py |
Adds local-install cleanup logic. |
scripts/version_utils.py |
Invokes cleanup after bumps. |
util/opentelemetry-util-genai/tests/test_version_utils.py |
Tests cleanup and release behavior. |
.github/workflows/release-all.yml |
Supplies packaging during bumps. |
.github/workflows/_release-finalize.yml |
Supplies packaging during finalization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #433, related to #787.
version_utils.py bumpnow removes local installs fromtests/requirements.oldest.txtwhen the declared floor of that workspace dependency is already released. Without this, the post-release bump PR failsdeps-checkand the local installs have to be removed by hand (as in #790).The floor and the workspace version are compared with
.devignored, sobump --releaseleaves current-cycle local installs in place. Comments next to the removed lines are not touched.Verified by running the bump on the pre-#790 tree: it removes the same 15 lines and
check_deps.pypasses.