fix: share inter-query cache across all queries in an Engine - #1423
Merged
Merged
Conversation
anderseknert
approved these changes
Sep 14, 2026
anderseknert
left a comment
anderseknert
left a comment
Member
There was a problem hiding this comment.
Just a few nits, but LGTM
The cache was created inside Engine.query, so every Rego query got a fresh empty cache and http.send results were never reused between rules or input files. Create the cache once in EnableInterQueryCache and reuse it. Fixes #1085 Signed-off-by: James Alseth <james@jalseth.me>
jalseth
force-pushed
the
fix/inter-query-cache-per-engine
branch
from
September 19, 2026 16:24
33b859d to
5071cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache was created inside Engine.query, so every Rego query got a fresh empty cache and http.send results were never reused between rules or input files. Create the cache once in EnableInterQueryCache and reuse it.
Fixes #1085