Skip to content

chore: improve conftest maintenance path - #1336

Closed
otjdiepluong wants to merge 1 commit into
open-policy-agent:masterfrom
otjdiepluong:maint/20260520055117
Closed

otjdiepluong wants to merge 1 commit into
open-policy-agent:masterfrom
otjdiepluong:maint/20260520055117

Conversation

@otjdiepluong

Copy link
Copy Markdown

Summary:

  • Add unit tests in parser/docker/docker_test.go covering edge cases in the Dockerfile parser: multi-stage builds with AS aliases, comments interleaved with instructions, and continuation lines with backslashes. The existing parser is small (<200 lines) and current tests cover only the happy path; new table-driven cases would harden it without behavior changes.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@jalseth

jalseth commented Aug 11, 2026

Copy link
Copy Markdown
Member

This feels like auto-generated noise (similar to ipfs/kubo#11337 (comment)).

You also have not signed the DCO. If you sign the DCO and clean up the PR, we can reconsider.

@jalseth jalseth closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants