Fork Sync: Update from parent repository - #173
Merged
Merged
Conversation
Add a golden-rule bullet to AGENTS.md pointing AI coding agents at the portable compiler attribute wrappers defined in src/include/prte_config_bottom.h (pulled in transitively by prte_config.h). These macros — __prte_attribute_unused__, __prte_attribute_noreturn__, __prte_attribute_format__, __prte_attribute_deprecated__, and many more — expand to the appropriate __attribute__((...)) on compilers that support it and to nothing elsewhere. The new guidance tells agents to reach for them (for example, to mark an unused function parameter) rather than writing a bare __attribute__ or leaving a compiler warning unaddressed. Docs-only change to the agent guidance file; no code or build impact. Signed-off-by: Ralph Castain <rhc@pmix.org>
The collective-shrink-completion work (#2492) needs to drive a shrink that targets several daemons sitting on one branch of the radix routing tree at once, then confirm the tree is repaired in a single pass. Four container nodes do not build a routing tree deep enough to construct that scenario, so the compose file now defines ten nodes and a single grow onto eight of them yields a nine-daemon tree with real depth. While bringing the larger testbed up, two things silently cost time and are now written into the README so the next run avoids them. First, build.sh freezes the image at the HEAD it was built from, so an image predating the no-scheduler grow/shrink support makes a grow fail phase-one with PMIX_ERR_UNREACH (it still hunts for a scheduler that is not there) with no ras/plm verbose output to explain it; the README documents the symptom and the created-vs-commit-time check that catches it. Second, prte --daemonize detaches from stdio, so the quick-start redirect captures nothing and no amount of added verbosity helps; the README now shows running the HNP in the foreground under docker exec -d to capture its trace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.