[v6.0.x] coll/nbc return correct error code from progress during start of round - #14356
Merged
Conversation
Signed-off-by: Matthew Whitlock <mwhitlo@sandia.gov> (cherry picked from commit db0d427)
ompi-backport-bot
Bot
added
the
target:v6.0.x
hppritcha
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14353 to
v6.0.x.When a fault tolerance error causes NBC_Progress to return an error code, it will return the specific fault tolerance error code. NBC_Start_round is ignoring this and returning OMPI_ERROR instead of the correct code, which causes MPI functions to return MPI_ERR_OTHER instead of the correct fault tolerance error code.
This causes intermittent failures of Fenix's CI testing: sandialabs/Fenix#136