Skip to content

use-mpi: Fix issues with parameter naming and intent - #14229

Open
N00byKing wants to merge 2 commits into
open-mpi:mainfrom
N00byKing:missing_funcs_tests
Open

use-mpi: Fix issues with parameter naming and intent#14229
N00byKing wants to merge 2 commits into
open-mpi:mainfrom
N00byKing:missing_funcs_tests

Conversation

@N00byKing

@N00byKing N00byKing commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

In #14219 the fortran.py binding generator was adjusted to print the standard name from pympistd for each parameter instead of "x" for F90.

This PR adds the testing infra; split off since it depends on an update to pympistd (#14216).
Also means that CI will fail until its updated, so opening as draft until then.
Will rebase once both PRs are in.

For Github:
Depends on #14219 #14216

@github-actions

Copy link
Copy Markdown

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5d5aa8b: use-mpi: Add check for standard-compliant paramete...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@hppritcha

Copy link
Copy Markdown
Member

@N00byKing could you rebase on top of main? #14216 is merged into main now.

@N00byKing
N00byKing force-pushed the missing_funcs_tests branch from 5ed4cd3 to 4689d71 Compare August 3, 2026 08:02
@N00byKing N00byKing closed this Aug 11, 2026
@N00byKing
N00byKing force-pushed the missing_funcs_tests branch from 4689d71 to fc91e63 Compare August 11, 2026 07:10
@N00byKing N00byKing reopened this Aug 11, 2026
@N00byKing
N00byKing marked this pull request as ready for review August 11, 2026 07:30
@N00byKing
N00byKing force-pushed the missing_funcs_tests branch from 6d2c629 to c931ce0 Compare August 11, 2026 07:32
Comment thread ompi/mpi/bindings/check_fortran_param_names.py
@N00byKing

Copy link
Copy Markdown
Contributor Author

Now that #14219 is in I've rebased and marked ready for review.
Looking for some opinions regarding the intent issue

@hppritcha
hppritcha self-requested a review August 12, 2026 14:47

@jsquyres jsquyres left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Verdict: COMMENT

Findings (2 validated from 5 raw)

  • Agreed (cross-source): 0
  • codex-reviewer: 1
  • v3-reviewer: 1
  • Description accuracy: 0

Filter Pipeline

  • Dropped (no quote): 0
  • Dropped (hallucination): 0 (path: 0, quote: 0, deleted: 0)
  • Suppressed (dedup): 0
  • Dropped (below cutoff): 3

codex-reviewer

[Test coverage | MEDIUM] ompi/mpi/bindings/check_fortran_param_names.py:12see inline comment

v3-reviewer

[Cross-file consistency | MEDIUM] ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h.in:599see inline comment

Comment thread ompi/mpi/bindings/check_fortran_param_names.py
Comment thread ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h.in
@N00byKing
N00byKing force-pushed the missing_funcs_tests branch from c931ce0 to 04baf95 Compare August 14, 2026 07:52
@github-actions

Copy link
Copy Markdown

Hello! The Git Commit Checker CI bot found a few problems with this PR:

99ef34f: docs: Fix argument names and direction

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@N00byKing
N00byKing force-pushed the missing_funcs_tests branch from 99ef34f to c635d99 Compare August 14, 2026 08:37
@N00byKing

Copy link
Copy Markdown
Contributor Author

functions are checked now as well, and I've updated the docs+changelog.
I wasn't sure where to put the changelog entries considering that 6 isn't released yet and I don't know if this will be backported, so I just put it in the newest one.

hppritcha
hppritcha previously approved these changes Aug 19, 2026
@hppritcha

Copy link
Copy Markdown
Member

we'll update 6.0.x as part of backport of this PR to that branch.

@hppritcha

Copy link
Copy Markdown
Member

@jsquyres double check when you have a chance

Signed-off-by: Yussur Mustafa Oraji <yussur.oraji@tu-darmstadt.de>
Signed-off-by: Yussur Mustafa Oraji <yussur.oraji@tu-darmstadt.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants