use-mpi: Fix issues with parameter naming and intent - #14229
Conversation
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 5d5aa8b: use-mpi: Add check for standard-compliant paramete...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
5d5aa8b to
5ed4cd3
Compare
|
@N00byKing could you rebase on top of main? #14216 is merged into main now. |
5ed4cd3 to
4689d71
Compare
4689d71 to
fc91e63
Compare
6d2c629 to
c931ce0
Compare
|
Now that #14219 is in I've rebased and marked ready for review. |
jsquyres
left a comment
There was a problem hiding this comment.
Review Summary
Verdict: COMMENT
Findings (2 validated from 5 raw)
- Agreed (cross-source): 0
- codex-reviewer: 1
- v3-reviewer: 1
- Description accuracy: 0
Filter Pipeline
- Dropped (no quote): 0
- Dropped (hallucination): 0 (path: 0, quote: 0, deleted: 0)
- Suppressed (dedup): 0
- Dropped (below cutoff): 3
codex-reviewer
[Test coverage | MEDIUM] ompi/mpi/bindings/check_fortran_param_names.py:12 — see inline comment
v3-reviewer
[Cross-file consistency | MEDIUM] ompi/mpi/fortran/use-mpi-ignore-tkr/mpi-ignore-tkr-interfaces.h.in:599 — see inline comment
c931ce0 to
04baf95
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 99ef34f: docs: Fix argument names and direction
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
99ef34f to
c635d99
Compare
|
|
|
we'll update 6.0.x as part of backport of this PR to that branch. |
|
@jsquyres double check when you have a chance |
Signed-off-by: Yussur Mustafa Oraji <yussur.oraji@tu-darmstadt.de>
Signed-off-by: Yussur Mustafa Oraji <yussur.oraji@tu-darmstadt.de>
c635d99 to
fe10702
Compare
In #14219 the fortran.py binding generator was adjusted to print the standard name from pympistd for each parameter instead of "x" for F90.
This PR adds the testing infra; split off since it depends on an update to pympistd (#14216).
Also means that CI will fail until its updated, so opening as draft until then.
Will rebase once both PRs are in.
For Github:Depends on #14219 #14216