chore(count-aggregator-ui): export cn and typecheck tests from tsconfig.json - #229
Conversation
…include lib vitest files
🦋 Changeset detectedLatest commit: 2975938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR updates @mapsight/count-aggregator-ui’s public API and TypeScript configuration so that test files are typechecked via the package’s main tsconfig.json, while keeping the build output emitted via a dedicated build config. It also broadens Vitest’s include patterns for traffic-style and adds documentation clarifying CMS stylesheet/portal usage expectations.
Changes:
- Export
cnfrom@mapsight/count-aggregator-ui’s main entrypoint. - Consolidate typechecking into
tsconfig.json(noEmit: true) and shift emitting builds totsconfig.build.json(noEmit: false), removingtsconfig.test.json. - Expand
traffic-styleVitest include globs and add CMS stylesheet load-order guidance in the UI README.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/traffic-style/vitest.config.ts | Adds a Vitest include glob for top-level src/lib/*.test.ts. |
| packages/count-aggregator-ui/tsconfig.test.json | Removes the separate test tsconfig. |
| packages/count-aggregator-ui/tsconfig.json | Enables noEmit and allows tests under src/ to be typechecked by default. |
| packages/count-aggregator-ui/tsconfig.build.json | Ensures builds still emit outputs by overriding noEmit and keeping test exclusions. |
| packages/count-aggregator-ui/src/index.ts | Exports cn from ./lib/utils.js as part of the public API. |
| packages/count-aggregator-ui/README.md | Documents CMS stylesheet load order and portal guidance for embeds. |
| packages/count-aggregator-ui/package.json | Simplifies typecheck to a single tsc --noEmit run. |
| .changeset/count-aggregator-ui-tsconfig-export-cn.md | Adds a changeset describing the patch-level change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
cnfrom@mapsight/count-aggregator-uiand typecheck tests from the packagetsconfig.json.traffic-stylelib tests in Vitest.