Skip to content

chore(count-aggregator-ui): export cn and typecheck tests from tsconfig.json - #229

Merged
pjeweb merged 1 commit into
mainfrom
chore/count-aggregator-ui-hygiene
Aug 27, 2026
Merged

chore(count-aggregator-ui): export cn and typecheck tests from tsconfig.json#229
pjeweb merged 1 commit into
mainfrom
chore/count-aggregator-ui-hygiene

Conversation

@pjeweb

@pjeweb pjeweb commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Export cn from @mapsight/count-aggregator-ui and typecheck tests from the package tsconfig.json.
  • Document CMS stylesheet load order and include top-level traffic-style lib tests in Vitest.

@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2975938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mapsight/count-aggregator-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates @mapsight/count-aggregator-ui’s public API and TypeScript configuration so that test files are typechecked via the package’s main tsconfig.json, while keeping the build output emitted via a dedicated build config. It also broadens Vitest’s include patterns for traffic-style and adds documentation clarifying CMS stylesheet/portal usage expectations.

Changes:

  • Export cn from @mapsight/count-aggregator-ui’s main entrypoint.
  • Consolidate typechecking into tsconfig.json (noEmit: true) and shift emitting builds to tsconfig.build.json (noEmit: false), removing tsconfig.test.json.
  • Expand traffic-style Vitest include globs and add CMS stylesheet load-order guidance in the UI README.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/traffic-style/vitest.config.ts Adds a Vitest include glob for top-level src/lib/*.test.ts.
packages/count-aggregator-ui/tsconfig.test.json Removes the separate test tsconfig.
packages/count-aggregator-ui/tsconfig.json Enables noEmit and allows tests under src/ to be typechecked by default.
packages/count-aggregator-ui/tsconfig.build.json Ensures builds still emit outputs by overriding noEmit and keeping test exclusions.
packages/count-aggregator-ui/src/index.ts Exports cn from ./lib/utils.js as part of the public API.
packages/count-aggregator-ui/README.md Documents CMS stylesheet load order and portal guidance for embeds.
packages/count-aggregator-ui/package.json Simplifies typecheck to a single tsc --noEmit run.
.changeset/count-aggregator-ui-tsconfig-export-cn.md Adds a changeset describing the patch-level change.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pjeweb
pjeweb merged commit 6dba896 into main Aug 27, 2026
22 checks passed
@pjeweb
pjeweb deleted the chore/count-aggregator-ui-hygiene branch August 27, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants