feat(ui): add BottomSheet SCSS and map viewport sync - #223
Merged
Conversation
🦋 Changeset detectedLatest commit: 691e785 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pjeweb
force-pushed
the
feat/ui-bottom-sheet-chrome
branch
from
August 27, 2026 20:16
cc1f6e1 to
2ccc1da
Compare
There was a problem hiding this comment.
Pull request overview
Adds structural styling and a new UI hook to keep the map viewport consistent with an in-flow BottomSheet’s open/resize/close lifecycle, including optional selection dismissal.
Changes:
- Add
ms3-bottom-sheetstructural SCSS and wire it into the default SCSS bundle. - Introduce
useMapViewportSyncForBottomSheetto dispatchupdateMapSize(with optional recenter) and to clear configured feature selections on dismiss. - Add unit tests and Changesets entries for the new hook + SCSS.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/scss/default.scss | Includes the new BottomSheet SCSS block in the default SCSS bundle. |
| packages/ui/src/scss/blocks/_bottom-sheet.scss | Adds structural .ms3-bottom-sheet layout/state styles (dragging/scrollable modes). |
| packages/ui/src/js/hooks/useMapViewportSyncForBottomSheet.ts | New hook to resize/recenter map and optionally dismiss feature selection when BottomSheet changes. |
| packages/ui/src/js/hooks/useMapViewportSyncForBottomSheet.test.tsx | Adds tests for the new hook’s open-sync, scheduling coalescing, and selection dismiss behavior. |
| .changeset/ui-map-viewport-sync-bottom-sheet.md | Declares a minor release for the new hook API. |
| .changeset/ui-bottom-sheet-scss.md | Declares a patch release for the new SCSS block. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ms3-bottom-sheetSCSS for the#215BottomSheet layout states.useMapViewportSyncForBottomSheetso in-flow sheets can resize/recenter the map and dismiss selection.